|
|
|
Created:
12 years, 5 months ago by remyoudompheng Modified:
11 years, 11 months ago CC:
golang-codereviews Visibility:
Public. |
cmd/6g, cmd/8g: remove a useless temporary in comparison.
This temporary was used to work around cases where the frontend
would emit comparison between constants (revision 5327829ff1e4).
Patch Set 1 #Patch Set 2 : diff -r 2fe813f4f3c2 https://go.googlecode.com/hg/ #Patch Set 3 : diff -r 2fe813f4f3c2 https://go.googlecode.com/hg/ #
Total comments: 2
Total messages: 5
|
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
|
12 years, 5 months ago (2013年07月28日 15:50:30 UTC) #1 | |||||||||||||||||||||||
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c File src/cmd/6g/cgen.c (right): https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c#newcode1241 src/cmd/6g/cgen.c:1241: tempname(&n1, nl->type); This used to be a register. Why is it a temporary now? Also, you deleted a regalloc without deleting a regfree. If nl is itself a register, the regalloc below will mess things up.
https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c File src/cmd/6g/cgen.c (right): https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c#newcode1241 src/cmd/6g/cgen.c:1241: tempname(&n1, nl->type); Isn't this just a case where you want to use regalloc(&n1, nl->type, nl);?