|
|
|
main: Add a BigQuery example to google-api-go-client.
This example illustrates doing loading of objects stored in
Google Cloud Storage into BigQuery dataset tables.
Patch Set 1 #Patch Set 2 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #Patch Set 3 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #Patch Set 4 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #Patch Set 5 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #
Total comments: 2
Patch Set 6 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #
Total comments: 4
Patch Set 7 : diff -r 39e3e5baa72c https://code.google.com/p/google-api-go-client/ #Total messages: 7
|
garrick
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/google-api-go-client/
|
12 years, 5 months ago (2013年07月28日 03:16:23 UTC) #1 |
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/google-api-go-client/
https://codereview.appspot.com/11978043/diff/9001/examples/main.go File examples/main.go (right): https://codereview.appspot.com/11978043/diff/9001/examples/main.go#newcode5 examples/main.go:5: // This file is the same as the go-api-demo main.go with the modification is it?
https://codereview.appspot.com/11978043/diff/9001/examples/main.go File examples/main.go (right): https://codereview.appspot.com/11978043/diff/9001/examples/main.go#newcode5 examples/main.go:5: // This file is the same as the go-api-demo main.go with the modification On 2013年07月30日 06:19:45, adg wrote: > is it? removed. also updated below to include client id in hash/remove from cache file name.
https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go File examples/bigquery.go (right): https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go#newco... examples/bigquery.go:301: if job.Status.State == JobStatusDone { if job.Status.State != JobStatusDone { jobq.PushBack(job) continue } and unindent the rest https://codereview.appspot.com/11978043/diff/20001/examples/main.go File examples/main.go (right): https://codereview.appspot.com/11978043/diff/20001/examples/main.go#newcode159 examples/main.go:159: randState := fmt.Sprintf("st%d", time.Now().UnixNano()) Why?
https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go File examples/bigquery.go (right): https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go#newco... examples/bigquery.go:301: if job.Status.State == JobStatusDone { On 2013年07月31日 06:31:02, adg wrote: > if job.Status.State != JobStatusDone { > jobq.PushBack(job) > continue > } > and unindent the rest Done. https://codereview.appspot.com/11978043/diff/20001/examples/main.go File examples/main.go (right): https://codereview.appspot.com/11978043/diff/20001/examples/main.go#newcode159 examples/main.go:159: randState := fmt.Sprintf("st%d", time.Now().UnixNano()) On 2013年07月31日 06:31:02, adg wrote: > Why? govet flagged this - presumably for formatting a struct with %d
LGTM
*** Submitted as https://code.google.com/p/google-api-go-client/source/detail?r=112f598ccd42 *** main: Add a BigQuery example to google-api-go-client. This example illustrates doing loading of objects stored in Google Cloud Storage into BigQuery dataset tables. R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/11978043 Committer: Andrew Gerrand <adg@golang.org>