Keyboard Shortcuts
File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(157)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1140043: code review 1140043: A patch to help the codereview hg extension play nicely...

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by pwil3058
Modified:
6 years, 9 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.
A patch to help the codereview hg extension play nicely with MQ If you received this message it has passed its first.

Patch Set 1 #

Patch Set 2 : code review 1140043: A patch to help the codereview hg extension play nicely... #

Created: 15 years, 8 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M lib/codereview/codereview.py View 3 chunks +14 lines, -4 lines 0 comments Download
Total messages: 5
|
pwil3058
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 8 months ago (2010年05月08日 05:46:25 UTC) #1 
Hello rsc (cc: golang-dev@googlegroups.com),
I'd like you to review this change.
Sign in to reply to this message.
rsc
LGTM
15 years, 7 months ago (2010年05月19日 05:38:43 UTC) #2 
LGTM
Sign in to reply to this message.
rsc
Please complete the CLA as described at http://golang.org/doc/contribute.html#copyright so that I can apply this patch. ...
15 years, 7 months ago (2010年05月19日 05:40:46 UTC) #3 
Please complete the CLA as described at
http://golang.org/doc/contribute.html#copyright
so that I can apply this patch.
Thanks.
Sign in to reply to this message.
pwil3058
On 19/05/10 15:40, rsc@golang.org wrote: > Please complete the CLA as described at > http://golang.org/doc/contribute.html#copyright ...
15 years, 7 months ago (2010年05月19日 11:38:47 UTC) #4 
On 19/05/10 15:40, rsc@golang.org wrote:
> Please complete the CLA as described at
> http://golang.org/doc/contribute.html#copyright
> so that I can apply this patch.
Done (electronically).
Peter
Sign in to reply to this message.
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=c7ac1ecc0ac6 *** codereview: work better with mq R=rsc CC=golang-dev http://codereview.appspot.com/1140043 Committer: Russ ...
15 years, 7 months ago (2010年05月24日 21:37:03 UTC) #5 
*** Submitted as http://code.google.com/p/go/source/detail?r=c7ac1ecc0ac6 ***
codereview: work better with mq
R=rsc
CC=golang-dev
http://codereview.appspot.com/1140043
Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /