Can't Edit
Can't Publish+Mail
Start Review

cmd/5l: use more standard calling convention The standard ARM calling convention is that the function prologue should push LR onto the stack and then further subtract from SP to carve out a stack frame if needed. To date, the 5l calling convention has been to subtract from SP to carve out the stack frame and then push LR, with those two things happening in a single instruction. Switching to the standard calling convention should be less confusing to people familiar with ARM but new to the 5g/5l toolchain. It does cost an extra instruction when the stack frame is more than zero bytes, but this cost is small and, again, standard. Switching happens to make the stacks look exactly like x86 stacks, so they will also be less confusing to people familiar with x86. Switching will allow us to merge the runtime traceback code into a single file, which will reduce maintenance costs. Fixes issue 5113.