Issue 110077: Limited precision in SkScan_Path.cpp edge_compare()

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(99)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 110077: Limited precision in SkScan_Path.cpp edge_compare()

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 4 months ago by Stephen White

Modified:
16 years, 4 months ago

Reviewers:
reed

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Because this code is called with 14.18 fixed point values during antialiasing, using "valuea - valueb" as a comparison causes integer overflows for moderate values of valuea and valueb of opposite sign (eg., valuea = 8000.0f, valueb = -8000.0f). See http://crbug.com/18896, layout test LayoutTests/svg/carto.net/window.svg.

Patch Set 1 #

Created: 16 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
src/core/SkScan_Path.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 1

Stephen White

16 years, 4 months ago (2009年08月24日 22:21:41 UTC) #1