|
|
|
environs/localstorage: new package
We move the functionality from environs/local
and export relevant methods.
https://code.launchpad.net/~rogpeppe/juju-core/336-environs-localstorage/+merge/171774
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 4
Patch Set 2 : environs/localstorage: new package #Patch Set 3 : environs/localstorage: new package #
Total messages: 4
|
rog
Please take a look.
|
12 years, 6 months ago (2013年06月27日 11:15:12 UTC) #1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
Please take a look.
Very nice, LGTM, just one suggestion. https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend.go File environs/localstorage/backend.go (left): https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend.... environs/localstorage/backend.go:23: environName string yay! https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... File environs/localstorage/backend_test.go (right): https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... environs/localstorage/backend_test.go:125: c.Assert(resp.StatusCode, Equals, 200) s/200/http.StatusOK/ ?
LGTM. One hint: in environs/testing.EC2HTTPTestStorage I encapsulated the listener and added a Stop() method that closes the listener. So the whole backend would be one type. https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... File environs/localstorage/backend_test.go (right): https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... environs/localstorage/backend_test.go:125: c.Assert(resp.StatusCode, Equals, 200) On 2013年06月27日 11:18:29, dimitern wrote: > s/200/http.StatusOK/ ? +1
Please take a look. https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... File environs/localstorage/backend_test.go (right): https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_... environs/localstorage/backend_test.go:125: c.Assert(resp.StatusCode, Equals, 200) On 2013年06月27日 11:18:29, dimitern wrote: > s/200/http.StatusOK/ ? Done.