Issue 106250043: godeps: fix fetch bug

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(301)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 106250043: godeps: fix fetch bug

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+224873

Visibility:
Public.

godeps: fix fetch bug Fetch dependencies correctly even when the dependency does not currently exist. Change behaviour to fetch dependencies by default (it's almost always what you want). Deprecate the old flag and add -F flag to revert to old behaviour. https://code.launchpad.net/~rogpeppe/godeps/fetch-when-non-existent/+merge/224873 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : godeps: fix fetch bug #

Patch Set 3 : godeps: fix fetch bug #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -46 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	godeps.go	View	1 2	11 chunks	+96 lines, -44 lines	0 comments	Download
M	godeps_test.go	View	1 2	3 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 2

rog

Please take a look.

11 years, 6 months ago (2014年06月27日 16:40:32 UTC) #1

Please take a look.

rog

*** Submitted: godeps: fix fetch bug Fetch dependencies correctly even when the dependency does not ...

11 years, 6 months ago (2014年07月02日 10:55:22 UTC) #2

*** Submitted:
godeps: fix fetch bug
Fetch dependencies correctly even when the dependency does not currently
exist.
Change behaviour to fetch dependencies by default (it's almost always
what you want). Deprecate the old flag and add -F flag to revert to
old behaviour.
R=
CC=
https://codereview.appspot.com/106250043