Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10617044: Decorate section headers in review list.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by sadrul
Modified:
12 years, 6 months ago
Reviewers:
Andi
Visibility:
Public.
Decorate section headers in review list.

Patch Set 1 : . #

Created: 12 years, 6 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M templates/user.html View 6 chunks +6 lines, -6 lines 0 comments Download
Total messages: 5
|
sadrul
Hi! Having this should make it possible for extensions to move the issue-blocks around, so ...
12 years, 6 months ago (2013年06月26日 16:58:07 UTC) #1
Hi! Having this should make it possible for extensions to move the issue-blocks
around, so change-averse devs like myself can continue to use the old layout! :)
[ https://codereview.appspot.com/9971043/ seems to have stalled, and this is a
simple workaround. The relevant chromium-dev@ thread is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/92t4yyGOm-M ]
Sign in to reply to this message.
Andi
LGTM Thanks for pointing me to the discussion on chromium-dev. After skimming through the thread ...
12 years, 6 months ago (2013年06月27日 06:50:40 UTC) #2
LGTM
Thanks for pointing me to the discussion on chromium-dev. After skimming through
the thread I understand why there are some discussions regarding the UI changes
and I agree to some of the arguments there.
Sign in to reply to this message.
sadrul
On 2013年06月27日 06:50:40, Andi wrote: > LGTM > > Thanks for pointing me to the ...
12 years, 6 months ago (2013年06月27日 15:40:31 UTC) #3
On 2013年06月27日 06:50:40, Andi wrote:
> LGTM
> 
> Thanks for pointing me to the discussion on chromium-dev. After skimming
through
> the thread I understand why there are some discussions regarding the UI
changes
> and I agree to some of the arguments there.
Thanks! Mind committing this patch (or is there a better way to commit patches
for rietveld)? :)
Sign in to reply to this message.
Andi
Am Donnerstag, 27. Juni 2013 schrieb : > On 2013年06月27日 06:50:40, Andi wrote: > >> ...
12 years, 6 months ago (2013年06月27日 15:53:52 UTC) #4
Am Donnerstag, 27. Juni 2013 schrieb :
> On 2013年06月27日 06:50:40, Andi wrote:
>
>> LGTM
>>
>
> Thanks for pointing me to the discussion on chromium-dev. After
>>
> skimming through
>
>> the thread I understand why there are some discussions regarding the
>>
> UI changes
>
>> and I agree to some of the arguments there.
>>
>
> Thanks! Mind committing this patch (or is there a better way to commit
> patches for rietveld)? :)
It's already committed and live on this instance. Let me know if you're
missing something!
--Andi
>
>
https://codereview.appspot.**com/10617044/<https://codereview.appspot.com/106...
>
Sign in to reply to this message.
sadrul
On 2013年06月27日 15:53:52, Andi wrote: > Am Donnerstag, 27. Juni 2013 schrieb : > > ...
12 years, 6 months ago (2013年06月27日 15:56:50 UTC) #5
On 2013年06月27日 15:53:52, Andi wrote:
> Am Donnerstag, 27. Juni 2013 schrieb :
> 
> > On 2013年06月27日 06:50:40, Andi wrote:
> >
> >> LGTM
> >>
> >
> > Thanks for pointing me to the discussion on chromium-dev. After
> >>
> > skimming through
> >
> >> the thread I understand why there are some discussions regarding the
> >>
> > UI changes
> >
> >> and I agree to some of the arguments there.
> >>
> >
> > Thanks! Mind committing this patch (or is there a better way to commit
> > patches for rietveld)? :)
> 
> 
> It's already committed and live on this instance. Let me know if you're
> missing something!
Oh, sweet! Thanks!
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /