Issue 105780043: acme: make differential searches incremental with 9p write .../addr messages

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(266)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 105780043: acme: make differential searches incremental with 9p write .../addr messages

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by smckean83

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
codebot

Visibility:
Public.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
M	src/cmd/acme/xfid.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

smckean83

11 years, 7 months ago (2014年06月02日 18:51:09 UTC) #1

rsc

I'm sure this does what you want it to do but I don't believe this ...

11 years, 7 months ago (2014年06月02日 19:20:22 UTC) #2

I'm sure this does what you want it to do but I don't believe this is
backward compatible with what other clients may expect. Other clients may
well expect that addr=0 whenever they have just opened the addr file.