Issue 105103: Fully init SkPaints.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(147)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 105103: Fully init SkPaints.

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by agl

Modified:
16 years, 5 months ago

Reviewers:
reed

Visibility:
Public.

Fully init SkPaints. On 32-bit Linux, the current SkPaint structure is 60 bytes long. However, the last two bytes of that are just padding and the current SkPaint constructor never modifies them. But, when calling SkPaint::operator==, the memcmp is performed over the whole structure, including the random padding bytes and will often fail. For example: SkPaint a, b; if (a == b) { ... is undefined without this patch.

Patch Set 1 #

Created: 16 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
M	src/core/SkPaint.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1

agl

16 years, 5 months ago (2009年08月13日 17:52:19 UTC) #1