|
|
|
state/apiserver: logging in changes the API
This is a step towards serving just the API
that each client is supposed to see.
For the time being, we still have one
big root object, but this will be split up
in subsequent CLs.
https://code.launchpad.net/~rogpeppe/juju-core/320-apiserver-login-choose-api/+merge/170939
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : state/apiserver: logging in changes the API #
Total comments: 3
Total messages: 4
|
rog
Please take a look.
|
12 years, 6 months ago (2013年06月22日 08:55:03 UTC) #1 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Please take a look.
Nice CL, LGTM. Only one comment. https://codereview.appspot.com/10447047/diff/3001/state/apiserver/admin.go File state/apiserver/admin.go (right): https://codereview.appspot.com/10447047/diff/3001/state/apiserver/admin.go#ne... state/apiserver/admin.go:76: // about existing entities. +1 https://codereview.appspot.com/10447047/diff/3001/state/apiserver/apiserver.go File state/apiserver/apiserver.go (right): https://codereview.appspot.com/10447047/diff/3001/state/apiserver/apiserver.g... state/apiserver/apiserver.go:116: func serverError(err error) error { Not really happy with the name, missing a verb in front of it. Named with a noun it more sounds like a type or instance instead of a function that does something.
thanks for the review. https://codereview.appspot.com/10447047/diff/3001/state/apiserver/apiserver.go File state/apiserver/apiserver.go (right): https://codereview.appspot.com/10447047/diff/3001/state/apiserver/apiserver.g... state/apiserver/apiserver.go:116: func serverError(err error) error { On 2013年06月24日 11:51:35, mue wrote: > Not really happy with the name, missing a verb in front of it. Named with a noun > it more sounds like a type or instance instead of a function that does > something. That's the name we're currently using (see common.ServerError). If you think this bikeshed is the wrong colour, feel free to propose a branch that changes the name. For the record, it's not uncommon in Go to name functions by what they return rather than what they do. For example: http://golang.org/pkg/net/http/#StatusText