Issue 10148044: rpc: allow dynamic change of API

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(17)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10148044: rpc: allow dynamic change of API

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by rog

Modified:
12 years, 6 months ago

Reviewers:
mue , mp+168476, fwereade

Visibility:
Public.

rpc: allow dynamic change of API This will allow us to change the available API in response to a login request. https://code.launchpad.net/~rogpeppe/juju-core/317-rpc-dynamic-serve/+merge/168476 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: allow dynamic change of API #

Patch Set 3 : rpc: allow dynamic change of API #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+767 lines, -291 lines)			Patch
M	.lbox.check	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/plugin_test.go	View	1 2	4 chunks	+3 lines, -2 lines	0 comments	Download
M	cmd/juju/status.go	View	1 2	10 chunks	+88 lines, -45 lines	0 comments	Download
M	cmd/juju/status_test.go	View	1 2	3 chunks	+97 lines, -0 lines	0 comments	Download
M	environs/azure/environ.go	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	environs/azure/instance.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	1 2	2 chunks	+42 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 2	16 chunks	+20 lines, -19 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2	17 chunks	+29 lines, -28 lines	0 comments	Download
M	environs/ec2/export_test.go	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	environs/ec2/live_test.go	View	1 2	5 chunks	+7 lines, -6 lines	0 comments	Download
M	environs/interface.go	View	1 2	5 chunks	+6 lines, -35 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2	9 chunks	+9 lines, -8 lines	0 comments	Download
M	environs/jujutest/tests.go	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	environs/maas/environ.go	View	1 2	10 chunks	+12 lines, -11 lines	0 comments	Download
M	environs/maas/environ_test.go	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
M	environs/maas/instance.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/openstack/local_test.go	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	environs/openstack/provider.go	View	1 2	20 chunks	+29 lines, -28 lines	0 comments	Download
M	environs/openstack/provider_test.go	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
A	instance/instance.go	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download
M	juju/testing/conn.go	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	rpc/rpc_test.go	View	18 chunks	+118 lines, -15 lines	0 comments	Download
M	rpc/server.go	View	7 chunks	+53 lines, -37 lines	0 comments	Download
M	state/container.go	View	1 2	3 chunks	+15 lines, -3 lines	0 comments	Download
M	state/export_test.go	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1 2	2 chunks	+13 lines, -2 lines	0 comments	Download
M	state/machine_test.go	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 2	1 chunk	+43 lines, -4 lines	0 comments	Download
M	state/state_test.go	View	1 2	3 chunks	+64 lines, -0 lines	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	worker/provisioner/broker.go	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	worker/provisioner/provisioner_task.go	View	1 2	7 chunks	+10 lines, -10 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3

rog

Please take a look.

12 years, 7 months ago (2013年06月10日 15:21:23 UTC) #1

Please take a look.