Issue 101410045: oauth2: cache write should return an error instead of invoking an error handler

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(418)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 101410045: oauth2: cache write should return an error instead of invoking an error handler

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jbd

Modified:
11 years, 6 months ago

Reviewers:
adg

Visibility:
Public.

More Reviews

oauth2: cache write should return an error instead of invoking an error handler

Patch Set 3 : #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
M	cache.go	View	1 2	3 chunks	+4 lines, -9 lines	0 comments	Download
M	cache_test.go	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	transport.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	transport_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3

jbd

11 years, 6 months ago (2014年06月22日 22:29:55 UTC) #1

adg

LGTM https://codereview.appspot.com/101410045/diff/20001/cache.go File cache.go (right): https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode16 cache.go:16: Read() (token *Token, err error) Read() (*Token, error) ...

11 years, 6 months ago (2014年06月22日 22:32:26 UTC) #2

LGTM
https://codereview.appspot.com/101410045/diff/20001/cache.go
File cache.go (right):
https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode16
cache.go:16: Read() (token *Token, err error)
Read() (*Token, error)
https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode18
cache.go:18: Write(token *Token) (err error)
Write(*Token) error
https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode49
cache.go:49: func (f *FileCache) Write(token *Token) (err error) {
s/(err error)/error/

jbd

Submitted. https://codereview.appspot.com/101410045/diff/20001/cache.go File cache.go (right): https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode16 cache.go:16: Read() (token *Token, err error) On 2014年06月22日 22:32:26, ...

11 years, 6 months ago (2014年06月22日 22:39:54 UTC) #3

Submitted.
https://codereview.appspot.com/101410045/diff/20001/cache.go
File cache.go (right):
https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode16
cache.go:16: Read() (token *Token, err error)
On 2014年06月22日 22:32:26, adg wrote:
> Read() (*Token, error)
Done.
https://codereview.appspot.com/101410045/diff/20001/cache.go#newcode18
cache.go:18: Write(token *Token) (err error)
On 2014年06月22日 22:32:26, adg wrote:
> Write(*Token) error
Done.

Issue 101410045: oauth2: cache write should return an error instead of invoking an error handler

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #