zkat/miette

Fork 0

Code Issues 83 Pull requests 12 Projects Releases 61 Activity Actions

returning owned data from `SpanContents::data` #410

New issue

Open

opened 2024年11月22日 06:14:57 +01:00 by Random-Scientist · 2 comments

Random-Scientist commented

2024年11月22日 06:14:57 +01:00

(Migrated from github.com)

Copy link

I have a scenario where source bytes for my custom SpanContents are potentially dynamically generated by each call to read_span on my source code, returning an Arc<str> (which is then stored in my SpanContents), and it would be very helpful to be able to return an opaque, possibly-owned value instead of &'a [u8] (something along the lines of impl AsRef<[u8]> + 'a)
edit 1 : impl AsRef<[u8]> + 'a breaks object safety (duh), looking for an alternative

I have a scenario where source bytes for my custom SpanContents are potentially dynamically generated by each call to `read_span` on my source code, returning an `Arc<str>` (which is then stored in my SpanContents), and it would be very helpful to be able to return an opaque, possibly-owned value instead of `&'a [u8]` (something along the lines of `impl AsRef<[u8]> + 'a`) edit 1 : `impl AsRef<[u8]> + 'a` breaks object safety (duh), looking for an alternative

Random-Scientist commented

2024年11月22日 07:00:33 +01:00

(Migrated from github.com)

Copy link

I realized after the fact that I can simply impl<'a> SpanContents<'a> for &'a MyOwnedSpanContents, which solves most of my issues.
edit: it didn't

I realized after the fact that I can simply `impl<'a> SpanContents<'a> for &'a MyOwnedSpanContents`, which solves most of my issues. edit: it didn't

Random-Scientist commented

2024年11月22日 07:15:12 +01:00

(Migrated from github.com)

Copy link

Reopening because that impl that "solved things" only pushed the issues I encountered up into the implementation of SourceCode

Reopening because that impl that "solved things" only pushed the issues I encountered up into the implementation of `SourceCode`

No Branch/Tag specified

Branches Tags

main

zkat/typed-report

Labels

Clear labels

breaking

A semver-major breaking change

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

epic

Tracking issue for other issues.

good first issue

Good for newcomers

Hacktoberfest

Stuff that's good for hacktoberfest contribs

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

zkat/miette#410

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

returning owned data from SpanContents::data #410

returning owned data from `SpanContents::data` #410