Add ActionState::Finally that always runs #35

ndarilek commented 2022年03月02日 20:43:24 +01:00 (Migrated from github.com)

I have actions that can succeed or fail. Independently of that, they generally need to run some cleanup to ensure that scorers know what has already been handled.

It'd be nice if actions first ran with ActionState::Success or ActionState::Failure, then an ActionState::Final match could handle all my cleanup. Now I'm performing all my cleanup in Success or Failure arms which is a bit confusing, particularly if I want a failure case but don't want to repeat the cleanup.

Thanks!

I have actions that can succeed or fail. Independently of that, they generally need to run some cleanup to ensure that scorers know what has already been handled. It'd be nice if actions first ran with `ActionState::Success` or `ActionState::Failure`, then an `ActionState::Final` match could handle all my cleanup. Now I'm performing all my cleanup in `Success` or `Failure` arms which is a bit confusing, particularly if I want a failure case but don't want to repeat the cleanup. Thanks!

zkat commented 2023年12月09日 23:42:37 +01:00

I can't think of a good way to implement this that doesn't make Actions dependent on definitely catching a single-frame run.

I can't think of a good way to implement this that doesn't make Actions dependent on definitely catching a single-frame run.

ekalosak commented 2024年05月16日 21:26:11 +02:00 (Migrated from github.com)

Maybe close as inactive? Or the author could sketch an implementation for feedback?

Maybe close as inactive? Or the author could sketch an implementation for feedback?