ziglang/zig
259
6.0k
Fork
You've already forked zig
771

x86_64: implement win64 abi for more vector types #35865

Merged
andrewrk merged 4 commits from jacobly/x86_64-win64-vec-abi into master 2026年06月21日 19:53:08 +02:00 AGit

Unblocks #35674 with:

--- a/test/tests.zig
+++ b/test/tests.zig
@@ -2019,35 +2019,35 @@ const c_abi_targets = blk: {
 },
 },
 
- //.{
- // .target = .{
- // .cpu_arch = .x86_64,
- // .os_tag = .windows,
- // .abi = .gnu,
- // },
- // .use_llvm = false,
- // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
- //},
- //.{
- // .target = .{
- // .cpu_arch = .x86_64,
- // .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v2 },
- // .os_tag = .windows,
- // .abi = .gnu,
- // },
- // .use_llvm = false,
- // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
- //},
- //.{
- // .target = .{
- // .cpu_arch = .x86_64,
- // .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v3 },
- // .os_tag = .windows,
- // .abi = .gnu,
- // },
- // .use_llvm = false,
- // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
- //},
+ .{
+ .target = .{
+ .cpu_arch = .x86_64,
+ .os_tag = .windows,
+ .abi = .gnu,
+ },
+ .use_llvm = false,
+ .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
+ },
+ .{
+ .target = .{
+ .cpu_arch = .x86_64,
+ .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v2 },
+ .os_tag = .windows,
+ .abi = .gnu,
+ },
+ .use_llvm = false,
+ .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
+ },
+ .{
+ .target = .{
+ .cpu_arch = .x86_64,
+ .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v3 },
+ .os_tag = .windows,
+ .abi = .gnu,
+ },
+ .use_llvm = false,
+ .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"},
+ },
 .{
 .target = .{
 .cpu_arch = .x86_64,
Unblocks #35674 with: ```diff --- a/test/tests.zig +++ b/test/tests.zig @@ -2019,35 +2019,35 @@ const c_abi_targets = blk: { }, }, - //.{ - // .target = .{ - // .cpu_arch = .x86_64, - // .os_tag = .windows, - // .abi = .gnu, - // }, - // .use_llvm = false, - // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, - //}, - //.{ - // .target = .{ - // .cpu_arch = .x86_64, - // .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v2 }, - // .os_tag = .windows, - // .abi = .gnu, - // }, - // .use_llvm = false, - // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, - //}, - //.{ - // .target = .{ - // .cpu_arch = .x86_64, - // .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v3 }, - // .os_tag = .windows, - // .abi = .gnu, - // }, - // .use_llvm = false, - // .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, - //}, + .{ + .target = .{ + .cpu_arch = .x86_64, + .os_tag = .windows, + .abi = .gnu, + }, + .use_llvm = false, + .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, + }, + .{ + .target = .{ + .cpu_arch = .x86_64, + .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v2 }, + .os_tag = .windows, + .abi = .gnu, + }, + .use_llvm = false, + .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, + }, + .{ + .target = .{ + .cpu_arch = .x86_64, + .cpu_model = .{ .explicit = &std.Target.x86.cpu.x86_64_v3 }, + .os_tag = .windows, + .abi = .gnu, + }, + .use_llvm = false, + .c_defines = &.{"ZIG_BACKEND_STAGE2_X86_64"}, + }, .{ .target = .{ .cpu_arch = .x86_64, ```
jacobly changed title from (削除) x86_64: implement win64 abi for bool vectors (削除ここまで) to x86_64: implement win64 abi for more vector types 2026年06月20日 12:46:26 +02:00
jacobly force-pushed jacobly/x86_64-win64-vec-abi from b72aca32c2
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
to 063b5b6753
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 44m23s
ci / x86_64-windows-release (pull_request) Failing after 44m9s
ci / x86_64-freebsd-release (pull_request) Successful in 45m18s
ci / x86_64-netbsd-debug (pull_request) Successful in 46m56s
ci / x86_64-openbsd-release (pull_request) Successful in 46m22s
ci / x86_64-freebsd-debug (pull_request) Successful in 49m35s
ci / x86_64-linux-debug (pull_request) Successful in 54m58s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h0m56s
ci / x86_64-windows-debug (pull_request) Failing after 1h1m38s
ci / aarch64-macos-release (pull_request) Successful in 1h8m12s
ci / aarch64-macos-debug (pull_request) Successful in 1h18m33s
ci / s390x-linux-release (pull_request) Successful in 1h24m50s
ci / aarch64-linux-release (pull_request) Successful in 1h34m51s
ci / powerpc64le-linux-release (pull_request) Successful in 2h20m43s
ci / aarch64-linux-debug (pull_request) Successful in 2h28m2s
ci / x86_64-linux-release (pull_request) Successful in 2h50m14s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h35m39s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h50m37s
ci / s390x-linux-debug (pull_request) Successful in 4h5m34s
ci / loongarch64-linux-release (pull_request) Failing after 2h3m52s
ci / loongarch64-linux-debug (pull_request) Failing after 3h1m43s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
2026年06月20日 13:12:04 +02:00
Compare
jacobly force-pushed jacobly/x86_64-win64-vec-abi from 063b5b6753
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 44m23s
ci / x86_64-windows-release (pull_request) Failing after 44m9s
ci / x86_64-freebsd-release (pull_request) Successful in 45m18s
ci / x86_64-netbsd-debug (pull_request) Successful in 46m56s
ci / x86_64-openbsd-release (pull_request) Successful in 46m22s
ci / x86_64-freebsd-debug (pull_request) Successful in 49m35s
ci / x86_64-linux-debug (pull_request) Successful in 54m58s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h0m56s
ci / x86_64-windows-debug (pull_request) Failing after 1h1m38s
ci / aarch64-macos-release (pull_request) Successful in 1h8m12s
ci / aarch64-macos-debug (pull_request) Successful in 1h18m33s
ci / s390x-linux-release (pull_request) Successful in 1h24m50s
ci / aarch64-linux-release (pull_request) Successful in 1h34m51s
ci / powerpc64le-linux-release (pull_request) Successful in 2h20m43s
ci / aarch64-linux-debug (pull_request) Successful in 2h28m2s
ci / x86_64-linux-release (pull_request) Successful in 2h50m14s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h35m39s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h50m37s
ci / s390x-linux-debug (pull_request) Successful in 4h5m34s
ci / loongarch64-linux-release (pull_request) Failing after 2h3m52s
ci / loongarch64-linux-debug (pull_request) Failing after 3h1m43s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
to f32ad4c93c
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 43m41s
ci / x86_64-freebsd-debug (pull_request) Successful in 46m20s
ci / x86_64-netbsd-debug (pull_request) Successful in 47m16s
ci / x86_64-freebsd-release (pull_request) Successful in 48m29s
ci / x86_64-linux-debug (pull_request) Successful in 53m23s
ci / x86_64-openbsd-release (pull_request) Successful in 55m38s
ci / x86_64-openbsd-debug (pull_request) Successful in 59m32s
ci / x86_64-windows-release (pull_request) Failing after 1h5m40s
ci / x86_64-windows-debug (pull_request) Failing after 1h9m46s
ci / aarch64-linux-release (pull_request) Successful in 1h27m12s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
2026年06月20日 21:35:00 +02:00
Compare
jacobly force-pushed jacobly/x86_64-win64-vec-abi from f32ad4c93c
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 43m41s
ci / x86_64-freebsd-debug (pull_request) Successful in 46m20s
ci / x86_64-netbsd-debug (pull_request) Successful in 47m16s
ci / x86_64-freebsd-release (pull_request) Successful in 48m29s
ci / x86_64-linux-debug (pull_request) Successful in 53m23s
ci / x86_64-openbsd-release (pull_request) Successful in 55m38s
ci / x86_64-openbsd-debug (pull_request) Successful in 59m32s
ci / x86_64-windows-release (pull_request) Failing after 1h5m40s
ci / x86_64-windows-debug (pull_request) Failing after 1h9m46s
ci / aarch64-linux-release (pull_request) Successful in 1h27m12s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
to 0e8c6e42ad
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
2026年06月20日 23:03:26 +02:00
Compare
jacobly force-pushed jacobly/x86_64-win64-vec-abi from 0e8c6e42ad
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
to 661ea25c69
Some checks failed
ci / x86_64-netbsd-release (pull_request) Failing after 29m38s
ci / x86_64-freebsd-debug (pull_request) Failing after 44m48s
ci / x86_64-netbsd-debug (pull_request) Failing after 47m41s
ci / x86_64-openbsd-release (pull_request) Failing after 50m26s
ci / x86_64-openbsd-debug (pull_request) Failing after 55m26s
ci / x86_64-linux-debug (pull_request) Failing after 57m49s
ci / x86_64-freebsd-release (pull_request) Failing after 39m48s
ci / x86_64-windows-debug (pull_request) Successful in 1h13m5s
ci / x86_64-windows-release (pull_request) Successful in 1h24m19s
ci / s390x-linux-release (pull_request) Successful in 1h31m46s
ci / aarch64-linux-release (pull_request) Successful in 1h35m40s
ci / x86_64-linux-release (pull_request) Failing after 2h8m20s
ci / powerpc64le-linux-release (pull_request) Successful in 2h14m14s
ci / aarch64-macos-release (pull_request) Successful in 2h22m49s
ci / aarch64-macos-debug (pull_request) Successful in 2h30m18s
ci / aarch64-linux-debug (pull_request) Successful in 2h39m14s
ci / s390x-linux-debug (pull_request) Successful in 2h40m12s
ci / loongarch64-linux-debug (pull_request) Failing after 3h4m25s
ci / loongarch64-linux-release (pull_request) Failing after 2h13m21s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 3h35m45s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
2026年06月20日 23:06:04 +02:00
Compare
jacobly force-pushed jacobly/x86_64-win64-vec-abi from 661ea25c69
Some checks failed
ci / x86_64-netbsd-release (pull_request) Failing after 29m38s
ci / x86_64-freebsd-debug (pull_request) Failing after 44m48s
ci / x86_64-netbsd-debug (pull_request) Failing after 47m41s
ci / x86_64-openbsd-release (pull_request) Failing after 50m26s
ci / x86_64-openbsd-debug (pull_request) Failing after 55m26s
ci / x86_64-linux-debug (pull_request) Failing after 57m49s
ci / x86_64-freebsd-release (pull_request) Failing after 39m48s
ci / x86_64-windows-debug (pull_request) Successful in 1h13m5s
ci / x86_64-windows-release (pull_request) Successful in 1h24m19s
ci / s390x-linux-release (pull_request) Successful in 1h31m46s
ci / aarch64-linux-release (pull_request) Successful in 1h35m40s
ci / x86_64-linux-release (pull_request) Failing after 2h8m20s
ci / powerpc64le-linux-release (pull_request) Successful in 2h14m14s
ci / aarch64-macos-release (pull_request) Successful in 2h22m49s
ci / aarch64-macos-debug (pull_request) Successful in 2h30m18s
ci / aarch64-linux-debug (pull_request) Successful in 2h39m14s
ci / s390x-linux-debug (pull_request) Successful in 2h40m12s
ci / loongarch64-linux-debug (pull_request) Failing after 3h4m25s
ci / loongarch64-linux-release (pull_request) Failing after 2h13m21s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 3h35m45s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
to 8ecc942ce8
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 44m51s
ci / x86_64-netbsd-release (pull_request) Successful in 47m12s
ci / x86_64-netbsd-debug (pull_request) Successful in 47m33s
ci / x86_64-windows-release (pull_request) Successful in 47m16s
ci / x86_64-freebsd-debug (pull_request) Successful in 50m7s
ci / x86_64-openbsd-release (pull_request) Successful in 51m14s
ci / x86_64-openbsd-debug (pull_request) Successful in 54m32s
ci / x86_64-windows-debug (pull_request) Successful in 1h2m25s
ci / aarch64-macos-release (pull_request) Successful in 1h9m28s
ci / x86_64-linux-debug (pull_request) Successful in 1h17m10s
ci / aarch64-macos-debug (pull_request) Successful in 1h17m25s
ci / s390x-linux-release (pull_request) Successful in 1h27m44s
ci / aarch64-linux-release (pull_request) Successful in 1h28m17s
ci / loongarch64-linux-release (pull_request) Successful in 2h1m25s
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-linux-debug (pull_request) Successful in 2h28m5s
ci / powerpc64le-linux-release (pull_request) Successful in 2h33m51s
ci / s390x-linux-debug (pull_request) Successful in 2h42m8s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h15m11s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h36m5s
ci / loongarch64-linux-debug (pull_request) Successful in 3h42m2s
ci / x86_64-linux-release (pull_request) Successful in 3h49m27s
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
2026年06月21日 03:08:44 +02:00
Compare
andrewrk requested changes 2026年06月21日 18:46:49 +02:00
Dismissed
andrewrk left a comment
Copy link

Things that would be nice in the writeup:

  • why is the prefix in zig.h now zig_e_zig_ instead of zig_
  • why is the new C ABI test coverage commented out? what would it take to have additional coverage enabled?
  • a basic summary of the problem and how you fixed it
  • what method did you use to come up with the new c_abi test coverage? if you used a script to generate them can you share it
Things that would be nice in the writeup: * why is the prefix in zig.h now `zig_e_zig_` instead of `zig_` * why is the new C ABI test coverage commented out? what would it take to have additional coverage enabled? * a basic summary of the problem and how you fixed it * what method did you use to come up with the new c_abi test coverage? if you used a script to generate them can you share it
Author
Owner
Copy link
  • I finally hit a case where some generated code wanted to use an identifier that clashed with a zig.h identifier, so I banned all identifiers starting with zig_, but this broke the hack of defining extern zig declarations in zig.h which exists until inline asm specifies the target (e.g. .x86_64 vs .c), so in the interest of not holding up the dependent PR, I just read some gcc docs and updated the hack to match what the C compiler needed it to be.
  • The new coverage depends on #35674 to pass, but that PR depends on this PR to pass, so I just commented out the tests to unblock the dependency loop (which I verified locally with both PRs applied, and any future breakage can be addressed in the other PR), with this PR being a bit too big to wait for the other PR to be reviewed before being merged.
  • The other PR is failing when the x86-64 backend attempts to emit certain vector types over the C abi, so I tried to find the minimum set of vector types that had full coverage of all the insane things clang can do, and it's a lot, and then I added support to the x86-64 backend for these types in both the sysv and win64 calling conventions, which was not previously reasonable to do for win64 without test coverage that will become possible with the improved coff linker.
  • I typed the tests using mostly rectangle editor commands for the repeating patterns in a sequence of numbers (all I really care about is that they are different within a test so that e.g. two parts of an argument aren't swapped between two registers which would pass if all the elements were the same or followed a trivially repeating pattern) for one element type, and then copy pasted it and replaced the element type with a different one. I try not to do much if any direct generation of tests with scripts because that makes it too easy to just have too many tests when the better solution would have been to pick a different testing strategy such as auto generation of types with a fuzzer that then generates some code with equivalent C and Zig definitions and produces a test corpus based on the code coverage of compiling that code with a self-hosted backend, but having input generation and code coverage in different processes is too advanced for the current fuzzer, or equivalently combining the test code and compiler into the same process, which I'm not sure how best to do. I think I did use a script to generate the bool vector test cases in previous PR, because it pretty difficult to generate a non-repeating sequence of bits (I did originally try manually using parity patterns which are, by definition, non repeating, but it's still too much to keep track of by hand). However, even then, I probably only used that for the literal contents of the vector literal, and then wrote the verification code by using editor commands to transform the literal to a sequence of asserts, and as usual the test itself catches any typos I might make.
- I finally hit a case where some generated code wanted to use an identifier that clashed with a `zig.h` identifier, so I banned all identifiers starting with `zig_`, but this broke the hack of defining extern zig declarations in `zig.h` which exists until inline asm specifies the target (e.g. `.x86_64` vs `.c`), so in the interest of not holding up the dependent PR, I just read some gcc docs and updated the hack to match what the C compiler needed it to be. - The new coverage depends on #35674 to pass, but that PR depends on this PR to pass, so I just commented out the tests to unblock the dependency loop (which I verified locally with both PRs applied, and any future breakage can be addressed in the other PR), with this PR being a bit too big to wait for the other PR to be reviewed before being merged. - The other PR is failing when the x86-64 backend attempts to emit certain vector types over the C abi, so I tried to find the minimum set of vector types that had full coverage of all the insane things clang can do, and it's a lot, and then I added support to the x86-64 backend for these types in both the sysv and win64 calling conventions, which was not previously reasonable to do for win64 without test coverage that will become possible with the improved coff linker. - I typed the tests using mostly rectangle editor commands for the repeating patterns in a sequence of numbers (all I really care about is that they are different within a test so that e.g. two parts of an argument aren't swapped between two registers which would pass if all the elements were the same or followed a trivially repeating pattern) for one element type, and then copy pasted it and replaced the element type with a different one. I try not to do much if any direct generation of tests with scripts because that makes it too easy to just have too many tests when the better solution would have been to pick a different testing strategy such as auto generation of types with a fuzzer that then generates some code with equivalent C and Zig definitions and produces a test corpus based on the code coverage of compiling that code with a self-hosted backend, but having input generation and code coverage in different processes is too advanced for the current fuzzer, or equivalently combining the test code and compiler into the same process, which I'm not sure how best to do. I think I did use a script to generate the bool vector test cases in previous PR, because it pretty difficult to generate a non-repeating sequence of bits (I did originally try manually using parity patterns which are, by definition, non repeating, but it's still too much to keep track of by hand). However, even then, I probably only used that for the literal contents of the vector literal, and then wrote the verification code by using editor commands to transform the literal to a sequence of asserts, and as usual the test itself catches any typos I might make.
andrewrk left a comment
Copy link

Nice work!

Nice work!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!35865
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "jacobly/x86_64-win64-vec-abi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?