ziglang/zig
262
6.0k
Fork
You've already forked zig
779

zig build test prints stale "failed command:" line on success when the test child writes to stderr #35202

Closed
opened 2026年05月04日 22:49:02 +02:00 by mattbrown · 2 comments

Zig Version

0.16.0

Steps to Reproduce and Observed Behavior

Also reproduces on master (lib/std/Build/Step/Run.zig as of 2026年05月04日 — the relevant code at lines 1635-1655 is unchanged in spirit from 0.16.0).

Run zig build test against any project where the test executable is linked against a native library that emits informational lines to stderr during normal test execution (libdatachannel, OpenSSL with verbose logging, any C++ library that logs through std::cerr, etc.). All tests pass and Build Summary reports success, but stderr looks like this:

 [rtc:2] rtc::impl::DtlsTransport::doRecv@597: DTLS recv: Handshake failed: SSL - The connection indicated an EOF
 [rtc:2] rtc::impl::DtlsTransport::doRecv@605: DTLS handshake failed
 ... (many similar lines from the linked library) ...
 failed command: ./.zig-cache/o/<hash>/test --cache-dir=./.zig-cache --seed=0x... --listen=-
 Build Summary: 17/17 steps succeeded; 331/331 tests passed
 test success
 +- run test 331 pass (331 total)
 +- ...

echo $? after the build returns 0. The "failed command:" line is misleading — the build summary correctly reports success and nothing has actually failed. The only signal something is wrong is the stale line in stderr.

Easiest way to reproduce locally: link libc and pthread, spawn a thread that calls fprintf(stderr, ...) once per test, and run zig build test.

Tracing the cause:

lib/std/Build/Step/Run.zig, in spawnChildAndCollect, sets step.result_failed_command as a placeholder before running the child (line 1635-1636 on master):

// If an error occurs, it's caused by this command:

assert(run.step.result_failed_command == null);
run.step.result_failed_command = try Step.allocPrintCmd(options.gpa, child.cwd, argv);

The non-zig_test path through evalGeneric clears this placeholder on success (line 1426). The zig_test path (line 1638-1655) does not — it returns null directly without freeing or nulling the field.

Then lib/compiler/build_runner.zig line 1383-1390 calls printErrorMessages whenever there is any error/warning content OR result_stderr.len > 0:

 if (s.result_error_bundle.errorMessageCount() > 0 or
 s.result_error_msgs.items.len > 0 or
 s.result_stderr.len > 0)
 {
 ...
 printErrorMessages(...) catch {};
 }

printErrorMessages then unconditionally prints failed command: ... if failing_step.result_failed_command is non-null (line 1515-1523), regardless of whether the step actually failed.

So benign child stderr is enough to flush a stale placeholder string out as if the command had failed.

Expected Behavior

When zig build test succeeds, no failed command: line should appear on stderr. The Build Summary already reports success; the additional line implies the test step failed when it did not.

To fix, two reasonable repair sites:

  1. Clear step.result_failed_command on the zig_test success path in Run.zig (mirrors the existing clear at line 1426 in the foreign-target path), or

  2. In build_runner.zig's printErrorMessages, skip the failed command: block when failing_step.state == .success.

Happy to send a PR for whichever the maintainers prefer. (1) is a ~5-line change, (2) is a one-liner.

### Zig Version 0.16.0 ### Steps to Reproduce and Observed Behavior Also reproduces on master (lib/std/Build/Step/Run.zig as of 2026年05月04日 — the relevant code at lines 1635-1655 is unchanged in spirit from 0.16.0). Run zig build test against any project where the test executable is linked against a native library that emits informational lines to stderr during normal test execution (libdatachannel, OpenSSL with verbose logging, any C++ library that logs through std::cerr, etc.). All tests pass and Build Summary reports success, but stderr looks like this: ``` [rtc:2] rtc::impl::DtlsTransport::doRecv@597: DTLS recv: Handshake failed: SSL - The connection indicated an EOF [rtc:2] rtc::impl::DtlsTransport::doRecv@605: DTLS handshake failed ... (many similar lines from the linked library) ... failed command: ./.zig-cache/o/<hash>/test --cache-dir=./.zig-cache --seed=0x... --listen=- Build Summary: 17/17 steps succeeded; 331/331 tests passed test success +- run test 331 pass (331 total) +- ... ``` echo $? after the build returns 0. The "failed command:" line is misleading — the build summary correctly reports success and nothing has actually failed. The only signal something is wrong is the stale line in stderr. Easiest way to reproduce locally: link libc and pthread, spawn a thread that calls fprintf(stderr, ...) once per test, and run zig build test. **Tracing the cause:** lib/std/Build/Step/Run.zig, in spawnChildAndCollect, sets step.result_failed_command as a placeholder before running the child (line 1635-1636 on master): // If an error occurs, it's caused by this command: ``` assert(run.step.result_failed_command == null); run.step.result_failed_command = try Step.allocPrintCmd(options.gpa, child.cwd, argv); ``` The non-zig_test path through evalGeneric clears this placeholder on success (line 1426). The zig_test path (line 1638-1655) does not — it returns null directly without freeing or nulling the field. Then lib/compiler/build_runner.zig line 1383-1390 calls printErrorMessages whenever there is any error/warning content OR result_stderr.len > 0: ``` if (s.result_error_bundle.errorMessageCount() > 0 or s.result_error_msgs.items.len > 0 or s.result_stderr.len > 0) { ... printErrorMessages(...) catch {}; } ``` printErrorMessages then unconditionally prints failed command: ... if failing_step.result_failed_command is non-null (line 1515-1523), regardless of whether the step actually failed. So benign child stderr is enough to flush a stale placeholder string out as if the command had failed. ### Expected Behavior When zig build test succeeds, no failed command: line should appear on stderr. The Build Summary already reports success; the additional line implies the test step failed when it did not. To fix, two reasonable repair sites: 1. Clear step.result_failed_command on the zig_test success path in Run.zig (mirrors the existing clear at line 1426 in the foreign-target path), or 2. In build_runner.zig's printErrorMessages, skip the failed command: block when failing_step.state == .success. Happy to send a PR for whichever the maintainers prefer. (1) is a ~5-line change, (2) is a one-liner.
Member
Copy link

Duplicate of #31077

Duplicate of #31077
linus 2026年05月04日 23:02:50 +02:00
  • closed this issue
  • removed the
    bug
    label
Member
Copy link
Also https://ziglang.org/code-of-conduct/#strict-no-llm-no-ai-policy
Sign in to join this conversation.
No Branch/Tag specified
master
elfv2
spork8
restricted
0.16.x
panic-rewrite
parking-futex-lockfree
windows-Io-cleanup
Io-watch
ParseCommandLineOptions
windows-async-files
poll-ring
debug-file-leaks-differently
debug-file-leaks
ProcessPrng
elfv2-dyn
jobserver
threadtheft
io-threaded-no-queue
0.15.x
Io.net
comptime-allocator
restricted-function-pointers
cli
wasm-linker-writer
wrangle-writer-buffering
sha1-stream
async-await-demo
fixes
0.14.x
ast-node-methods
macos-debug-info
make-vs-configure
fuzz-macos
sans-aro
ArrayList-reserve
incr-bug
llvm-ir-nosanitize-metadata
ci-tarballs
ci-scripts
threadpool
0.12.x
new-pkg-hash
json-diagnostics
more-doctests
rework-comptime-mutation
0.11.x
ci-perf-comment
stage2-async
0.10.x
autofix
0.9.x
aro
hcs
0.8.x
0.7.x
0.16.0
0.15.2
0.15.1
0.15.0
0.14.1
0.14.0
0.12.1
0.13.0
0.12.0
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.1
0.8.0
0.7.1
0.7.0
0.6.0
0.5.0
0.4.0
0.3.0
0.2.0
0.1.1
0.1.0
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig#35202
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?