ziglang/zig
259
6.0k
Fork
You've already forked zig
771

SPIR-V: emit OpTypeRuntimeArray for storage-buffer multi-pointer fields #35179

Closed
opened 2026年05月02日 22:26:55 +02:00 by quint · 0 comments
Contributor
Copy link

What this enables

Kernels can now declare runtime-sized storage buffers in Zig:

constbuf=gpu.runtimeArray(u32,0,0,"buf");// ...buf.*.data[i]=x;

The host picks the buffer size at dispatch time. Before this change, the buffer length had to be a compile-time constant (extern struct { data: [N]u32 }), so every input size needed its own .spv. Now one pipeline handles any size.

This unlocks push-constant-driven kernels that dispatch over arbitrary input.

SPIR-V output

Before this change, the emitted struct contained a pointer field, which did not match how the host writes the buffer (raw T[]):

%_ptr_StorageBuffer_uint = OpTypePointer StorageBuffer %uint
%_struct = OpTypeStruct %_ptr_StorageBuffer_uint ; pointer field

After, the struct contains a runtime array, which appears to be what GLSL and HLSL emit for the same source pattern:

%_runtimearr_uint = OpTypeRuntimeArray %uint
%_struct = OpTypeStruct %_runtimearr_uint ; runtime array field
OpDecorate %_runtimearr_uint ArrayStride 4
OpDecorate %_struct Block

Why a side-table?

As far as I can tell, Zig's type system has no "runtime array" type. The gpu.runtimeArray helper returns *addrspace(.storage_buffer) extern struct { data: [*]addrspace(.storage_buffer) T }, so the field is a multi-pointer ([*]T). The frontend appears to lowerbuf.*.data[i] = x to AIR roughly as:

  1. struct_field_ptr to get a pointer to the data field
  2. load to dereference and yield [*]T
  3. ptr_elem_ptr to index that pointer and yield *T
  4. store to write

On the SPIR-V side the field is now a runtime array rather than a pointer, so step 2 has nothing to load (no pointer is stored at offset 0; the array data starts there), and step 3 would emit OpPtrAccessChain on a multi-pointer when OpAccessChain into the runtime array is what's wanted.

I considered two ways to bridge this:

  • Change Zig's type system to model runtime arrays directly. This would presumably touch the language, the language spec, and every backend. I am not in a position to take that on.
  • Side-table in the SPIR-V backend that records "this SPIR-V id has SPIR-V type *OpTypeRuntimeArray<T> even though the Zig side sees a *[*]T." Backend-local, scoped to SPIR-V.

This patch takes the second option. I'd appreciate a sanity check from someone who knows the backend better than I do; this may not be the right shape.

How the side-table works

CodeGen.runtime_array_ptrs: AutoHashMapUnmanaged(Id, void). Membership is intended to mean "this id has SPIR-V type *RuntimeArray<T> even though the Zig type system thinks otherwise."

Three call sites cooperate:

  • structFieldPtr: when the field's Zig type is a multi-pointer in storage_buffer or uniform addrspace, emit one OpAccessChain step into the parent struct (yielding *RuntimeArray<T>), register the id, and return it. The Zig caller still sees a *[*]T.
  • airLoad: if the source pointer is registered, the load is treated as a no-op. Return the same id and re-register it. The intent is to translate "load [*]T from *[*]T" into "the same id is now treated as [*]T, but its real SPIR-V type stayed *RuntimeArray<T>."
  • ptrElemPtr: if the input pointer is registered, emit one OpAccessChain step into the runtime array (yielding *T), in place of the OpPtrAccessChain that would otherwise be emitted.

The intended invariant is that an id ends up in the set iff it was produced by structFieldPtr on a buffer-class runtime-array field, possibly propagated through some number of no-op loads. I have not proven this; it's just what the three patches together seem to guarantee on the cases I tried.

Known limitations

As far as I've tested, the side-table only catches the direct access pattern buf.*.data[i]. Anywhere the SPIR-V id can flow without going through airLoad or ptrElemPtr, membership is lost:

  • Assigning const data = buf.*.data; and then indexing data[i] later works in the cases I tried, because the assignment lowers to airLoad, which is patched.
  • Passing the [*]T as a function parameter is not handled. The callee would receive a SPIR-V id of type *RuntimeArray<T> declared as *[*]T, and indexing inside the callee would emit OpPtrAccessChain on a non-pointer. I expect this to fail validation but have not confirmed.
  • Taking the address of buf.*.data is not handled.
  • Storing the [*]T value into a local variable of pointer type is not handled.

There may be other AIR ops that need to propagate side-table membership that I haven't run into yet. Pointers welcome.


Reference/Draft Implementation: ed4b959ddd

## What this enables Kernels can now declare runtime-sized storage buffers in Zig: ```zig const buf = gpu.runtimeArray(u32, 0, 0, "buf"); // ... buf.*.data[i] = x; ``` The host picks the buffer size at dispatch time. Before this change, the buffer length had to be a compile-time constant (`extern struct { data: [N]u32 }`), so every input size needed its own `.spv`. Now one pipeline handles any size. This unlocks push-constant-driven kernels that dispatch over arbitrary input. ## SPIR-V output Before this change, the emitted struct contained a pointer field, which did not match how the host writes the buffer (raw `T[]`): ``` %_ptr_StorageBuffer_uint = OpTypePointer StorageBuffer %uint %_struct = OpTypeStruct %_ptr_StorageBuffer_uint ; pointer field ``` After, the struct contains a runtime array, which appears to be what GLSL and HLSL emit for the same source pattern: ``` %_runtimearr_uint = OpTypeRuntimeArray %uint %_struct = OpTypeStruct %_runtimearr_uint ; runtime array field OpDecorate %_runtimearr_uint ArrayStride 4 OpDecorate %_struct Block ``` ## Why a side-table? As far as I can tell, Zig's type system has no "runtime array" type. The `gpu.runtimeArray` helper returns `*addrspace(.storage_buffer) extern struct { data: [*]addrspace(.storage_buffer) T }`, so the field is a multi-pointer (`[*]T`). The frontend appears to lower`buf.*.data[i] = x` to AIR roughly as: 1. `struct_field_ptr` to get a pointer to the `data` field 2. `load` to dereference and yield `[*]T` 3. `ptr_elem_ptr` to index that pointer and yield `*T` 4. `store` to write On the SPIR-V side the field is now a runtime array rather than a pointer, so step 2 has nothing to load (no pointer is stored at offset 0; the array data starts there), and step 3 would emit `OpPtrAccessChain` on a multi-pointer when `OpAccessChain` into the runtime array is what's wanted. I considered two ways to bridge this: - **Change Zig's type system** to model runtime arrays directly. This would presumably touch the language, the language spec, and every backend. I am not in a position to take that on. - **Side-table in the SPIR-V backend** that records "this SPIR-V id has SPIR-V type `*OpTypeRuntimeArray<T>` even though the Zig side sees a `*[*]T`." Backend-local, scoped to SPIR-V. This patch takes the second option. I'd appreciate a sanity check from someone who knows the backend better than I do; this may not be the right shape. ## How the side-table works `CodeGen.runtime_array_ptrs: AutoHashMapUnmanaged(Id, void)`. Membership is intended to mean "this id has SPIR-V type `*RuntimeArray<T>` even though the Zig type system thinks otherwise." Three call sites cooperate: - **`structFieldPtr`**: when the field's Zig type is a multi-pointer in `storage_buffer` or `uniform` addrspace, emit one `OpAccessChain` step into the parent struct (yielding `*RuntimeArray<T>`), register the id, and return it. The Zig caller still sees a `*[*]T`. - **`airLoad`**: if the source pointer is registered, the load is treated as a no-op. Return the same id and re-register it. The intent is to translate "load `[*]T` from `*[*]T`" into "the same id is now treated as `[*]T`, but its real SPIR-V type stayed `*RuntimeArray<T>`." - **`ptrElemPtr`**: if the input pointer is registered, emit one `OpAccessChain` step into the runtime array (yielding `*T`), in place of the `OpPtrAccessChain` that would otherwise be emitted. The intended invariant is that an id ends up in the set iff it was produced by `structFieldPtr` on a buffer-class runtime-array field, possibly propagated through some number of no-op loads. I have not proven this; it's just what the three patches together seem to guarantee on the cases I tried. ## Known limitations As far as I've tested, the side-table only catches the direct access pattern `buf.*.data[i]`. Anywhere the SPIR-V id can flow without going through `airLoad` or `ptrElemPtr`, membership is lost: - Assigning `const data = buf.*.data;` and then indexing `data[i]` later works in the cases I tried, because the assignment lowers to `airLoad`, which is patched. - Passing the `[*]T` as a function parameter is not handled. The callee would receive a SPIR-V id of type `*RuntimeArray<T>` declared as `*[*]T`, and indexing inside the callee would emit `OpPtrAccessChain` on a non-pointer. I expect this to fail validation but have not confirmed. - Taking the address of `buf.*.data` is not handled. - Storing the `[*]T` value into a local variable of pointer type is not handled. There may be other AIR ops that need to propagate side-table membership that I haven't run into yet. Pointers welcome. --- Reference/Draft Implementation: ed4b959ddd
Sign in to join this conversation.
No Branch/Tag specified
master
elfv2
spork8
restricted
0.16.x
panic-rewrite
parking-futex-lockfree
windows-Io-cleanup
Io-watch
ParseCommandLineOptions
windows-async-files
poll-ring
debug-file-leaks-differently
debug-file-leaks
ProcessPrng
elfv2-dyn
jobserver
threadtheft
io-threaded-no-queue
0.15.x
Io.net
comptime-allocator
restricted-function-pointers
cli
wasm-linker-writer
wrangle-writer-buffering
sha1-stream
async-await-demo
fixes
0.14.x
ast-node-methods
macos-debug-info
make-vs-configure
fuzz-macos
sans-aro
ArrayList-reserve
incr-bug
llvm-ir-nosanitize-metadata
ci-tarballs
ci-scripts
threadpool
0.12.x
new-pkg-hash
json-diagnostics
more-doctests
rework-comptime-mutation
0.11.x
ci-perf-comment
stage2-async
0.10.x
autofix
0.9.x
aro
hcs
0.8.x
0.7.x
0.16.0
0.15.2
0.15.1
0.15.0
0.14.1
0.14.0
0.12.1
0.13.0
0.12.0
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.1
0.8.0
0.7.1
0.7.0
0.6.0
0.5.0
0.4.0
0.3.0
0.2.0
0.1.1
0.1.0
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig#35179
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?