ziglang/zig

Fork 772

Code Issues 708 Pull requests 292 Activity Actions 29

integration test coverage for fetching #31848

New issue

Open

opened 2026年04月13日 19:45:45 +02:00 by andrewrk · 1 comment

andrewrk commented

2026年04月13日 19:45:45 +02:00

Owner

Copy link

Currently there are some unit tests related to fetching but no integration test coverage for package fetching. This leads to regressions and makes it harder to accept contributions.

Some things that should be covered:

fetching from git
fetching from each kind of compressed tarball
fetching from http and https
ensuring the content hash does or does not match across various conditions
ensuring the packages cannot mutate file system outside of package directory
ensuring that "recompression" and fetching from that cached data yields correct content hash

These tests should be based on driving zig build --fetch, zig fetch, and direct interactions with the file system.

However, test coverage within this source tree should not depend on external networking being online; tests should be self-contained. Therefore, this test coverage might need to be at least partially in a separate repository, and we need a plan for how to integrate (or not) with CI.

Labeling as bug because this will probably find bugs.

Currently there are some unit tests related to fetching but no integration test coverage for package fetching. This leads to regressions and makes it harder to accept contributions. Some things that should be covered: * fetching from git * fetching from each kind of compressed tarball * fetching from http and https * ensuring the content hash does or does not match across various conditions * ensuring the packages cannot mutate file system outside of package directory * ensuring that "recompression" and fetching from that cached data yields correct content hash These tests should be based on driving `zig build --fetch`, `zig fetch`, and direct interactions with the file system. However, test coverage within this source tree should not depend on external networking being online; tests should be self-contained. Therefore, this test coverage might need to be at least partially in a separate repository, and we need a plan for how to integrate (or not) with CI. Labeling as bug because this will probably find bugs.

andrewrk added this to the Upcoming milestone

2026年04月13日 19:45:47 +02:00

andrewrk added the

bug

label

2026年04月13日 19:45:47 +02:00

andrewrk referenced this issue

2026年04月13日 19:47:17 +02:00

Package/Fetch: reject path deps that escape the parent package root #31818

andrewrk referenced this issue

2026年04月13日 19:55:45 +02:00

Package/Fetch: reject path deps that escape the parent package root #31818

alexrp added the

testing

build system

labels

2026年04月13日 20:14:14 +02:00

andrewrk referenced this issue

2026年04月21日 06:47:56 +02:00

package fetching fixes and enhancements #31992

mercenary commented

2026年04月21日 21:46:07 +02:00

Contributor

Copy link

My 2cents: fetching from HTTP should be possible (without external dependencies) by concurrently running an HTTP server and passing a loopback IP address to build and fetch. The biggest issue may be figuring out whether to include the test packages in the source tree or to generate them at test time (fill files in /tmp/ or something)

My 2cents: fetching from HTTP should be possible (without external dependencies) by concurrently running an [HTTP server](https://ziglang.org/documentation/master/std/#std.http.Server) and passing a loopback IP address to `build` and `fetch`. The biggest issue may be figuring out whether to include the test packages in the source tree or to generate them at test time (fill files in `/tmp/` or something)

No Branch/Tag specified

Branches Tags

master

elfv2

spork8

restricted

0.16.x

panic-rewrite

parking-futex-lockfree

windows-Io-cleanup

Io-watch

ParseCommandLineOptions

windows-async-files

poll-ring

debug-file-leaks-differently

debug-file-leaks

ProcessPrng

elfv2-dyn

jobserver

threadtheft

io-threaded-no-queue

0.15.x

Io.net

comptime-allocator

restricted-function-pointers

cli

wasm-linker-writer

wrangle-writer-buffering

sha1-stream

async-await-demo

fixes

0.14.x

ast-node-methods

macos-debug-info

make-vs-configure

fuzz-macos

sans-aro

ArrayList-reserve

incr-bug

llvm-ir-nosanitize-metadata

ci-tarballs

ci-scripts

threadpool

0.12.x

new-pkg-hash

json-diagnostics

more-doctests

rework-comptime-mutation

0.11.x

ci-perf-comment

stage2-async

0.10.x

autofix

0.9.x

aro

hcs

0.8.x

0.7.x

Labels

Clear labels

This proposal is planned.

The web application for interactive documentation and generation of its assets.

backend/c

The C backend outputs C source code.

backend/llvm

The LLVM backend outputs an LLVM bitcode module.

backend/self-hosted

The self-hosted backends produce machine code directly.

binutils

Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.

breaking

Implementing this issue could cause existing code to no longer compile or have different behavior.

build system

The Zig build system - zig build, std.Build, the build runner, and package management.

debug info

docs

An issue with documentation, e.g. the language reference or standard library doc comments.

error message

This issue points out an error message that is unhelpful and should be improved.

frontend

Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.

fuzzing

incremental

Reuse of internal compiler state for faster compilation.

lib/c

This issue relates to Zig's libc implementation and/or vendored libcs.

lib/compiler-rt

This issue relates to Zig's compiler-rt library.

lib/cxx

This issue relates to Zig's vendored libc++ and/or libc++abi.

lib/std

This issue relates to Zig's standard library.

lib/tsan

This issue relates to Zig's vendored libtsan.

lib/ubsan-rt

This issue relates to Zig's ubsan-rt library.

lib/unwind

This issue relates to Zig's vendored libunwind.

linking

Zig's integrated object file and incremental linker.

miscompilation

The compiler reports success but produces semantically incorrect code.

This issue suggests language modifications. If it also has the "accepted" label then it is planned.

release notes

This issue or pull request should be mentioned in the release notes.

testing

This issue is related to testing the compiler, standard library, or other parts of Zig.

zig cc

Zig as a drop-in C-family compiler.

zig fmt

The Zig source code formatter.

zig reduce

The Zig source code reduction tool.

bounty

https://ziglang.org/news/announcing-donor-bounties

bug

Observed behavior contradicts documented or intended behavior.

contributor-friendly

This issue is limited in scope and/or knowledge of project internals.

downstream

An issue with a third-party project that uses this project.

enhancement

Solving this issue will likely involve adding new logic or components to the codebase.

infra

optimization

A task to improve performance and/or resource usage.

question

No questions on the issue tracker; use a community space instead.

regression

Something that used to work in a previous version stopped working

upstream

An issue with a third-party project that this project uses.

use case

Describes a real use case that is difficult or impossible, but does not propose a solution.

No labels

Milestone

Clear milestone

No items

No milestone

Upcoming

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ziglang/zig#31848

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?