ziglang/zig

Fork 772

Code Issues 708 Pull requests 292 Activity Actions 30

std.http.Client.ConnectTcpOptions.timeout is ignored #31410

New issue

Open

opened 2026年03月06日 19:31:06 +01:00 by unplanned · 2 comments

unplanned commented

2026年03月06日 19:31:06 +01:00

Contributor

Copy link

Zig Version

0.16.0-dev.2565+684032671

Steps to Reproduce and Observed Behavior

Just looking at the code in std/http/Client.zig, the timeout field is never read. This is misleading, as its presence seems to indicate that it would be used.

Expected Behavior

The timeout should either be used or not be available.
However, since it is only an option for the connectTcpOptions function, and not the more standard request function, it is not that big of an issue.

### Zig Version 0.16.0-dev.2565+684032671 ### Steps to Reproduce and Observed Behavior Just looking at the code in `std/http/Client.zig`, the `timeout` field is never read. This is misleading, as its presence seems to indicate that it would be used. ### Expected Behavior The timeout should either be used or not be available. However, since it is only an option for the `connectTcpOptions` function, and not the more standard `request` function, it is not that big of an issue.

unplanned added the

bug

label

2026年03月06日 19:31:06 +01:00

alexrp added the

lib/std

label

2026年03月06日 19:42:14 +01:00

by965738071 commented

2026年03月10日 15:21:23 +01:00

Copy link

line 1451. add .timeout = options.timeout. I think . ok ?

line 1451. add `.timeout = options.timeout`. I think . ok ?

截屏2026年03月10日 22.19.25.png

315 KiB

截屏2026年03月10日 22.19.25.png

hello-world-bfree referenced this issue from a pull request that will close it,

2026年03月10日 18:18:40 +01:00

fix: wires up tcp connect timeout. Closes #31410 & #31305 #31449

mabis commented

2026年05月21日 21:25:03 +02:00

Copy link

hey, just bumped into this as well and came to open an issue only to discover it already exists (as almost always!)

My code does an opt-in auto-update check via std.http.Client.fetch() on startup. Under sustained CPU load the fetch could hang indefinitely without any timeout to bound it.

The workaround I ended up with[*] works but it's a heavy structural cost for what would be a one-line plumb in connectTcpOptions() (forwarding options.timeout into the host.connect(io, port, .{ .mode = .stream }) literal).

ConnectTcpOptions.timeout already exists as a field, it's just not threaded through.

[*] around 230 LOC: a background thread that does the fetch, plus a 50ms atomic poll loop on the main thread that detaches the thread + reports .network_failed if the 10s deadline is exceeded

hey, just bumped into this as well and came to open an issue only to discover it already exists (as almost always!) My code does an opt-in auto-update check via `std.http.Client.fetch()` on startup. Under sustained CPU load the fetch could hang indefinitely without any timeout to bound it. The workaround I ended up with[*] works but it's a heavy structural cost for what would be a one-line plumb in `connectTcpOptions()` (forwarding `options.timeout` into the `host.connect(io, port, .{ .mode = .stream })` literal). `ConnectTcpOptions.timeout` already exists as a field, it's just not threaded through. [*] around 230 LOC: a background thread that does the fetch, plus a 50ms atomic poll loop on the main thread that detaches the thread + reports `.network_failed` if the 10s deadline is exceeded

No Branch/Tag specified

Branches Tags

master

elfv2

spork8

restricted

0.16.x

panic-rewrite

parking-futex-lockfree

windows-Io-cleanup

Io-watch

ParseCommandLineOptions

windows-async-files

poll-ring

debug-file-leaks-differently

debug-file-leaks

ProcessPrng

elfv2-dyn

jobserver

threadtheft

io-threaded-no-queue

0.15.x

Io.net

comptime-allocator

restricted-function-pointers

cli

wasm-linker-writer

wrangle-writer-buffering

sha1-stream

async-await-demo

fixes

0.14.x

ast-node-methods

macos-debug-info

make-vs-configure

fuzz-macos

sans-aro

ArrayList-reserve

incr-bug

llvm-ir-nosanitize-metadata

ci-tarballs

ci-scripts

threadpool

0.12.x

new-pkg-hash

json-diagnostics

more-doctests

rework-comptime-mutation

0.11.x

ci-perf-comment

stage2-async

0.10.x

autofix

0.9.x

aro

hcs

0.8.x

0.7.x

Labels

Clear labels

This proposal is planned.

The web application for interactive documentation and generation of its assets.

backend/c

The C backend outputs C source code.

backend/llvm

The LLVM backend outputs an LLVM bitcode module.

backend/self-hosted

The self-hosted backends produce machine code directly.

binutils

Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.

breaking

Implementing this issue could cause existing code to no longer compile or have different behavior.

build system

The Zig build system - zig build, std.Build, the build runner, and package management.

debug info

docs

An issue with documentation, e.g. the language reference or standard library doc comments.

error message

This issue points out an error message that is unhelpful and should be improved.

frontend

Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.

fuzzing

incremental

Reuse of internal compiler state for faster compilation.

lib/c

This issue relates to Zig's libc implementation and/or vendored libcs.

lib/compiler-rt

This issue relates to Zig's compiler-rt library.

lib/cxx

This issue relates to Zig's vendored libc++ and/or libc++abi.

lib/std

This issue relates to Zig's standard library.

lib/tsan

This issue relates to Zig's vendored libtsan.

lib/ubsan-rt

This issue relates to Zig's ubsan-rt library.

lib/unwind

This issue relates to Zig's vendored libunwind.

linking

Zig's integrated object file and incremental linker.

miscompilation

The compiler reports success but produces semantically incorrect code.

This issue suggests language modifications. If it also has the "accepted" label then it is planned.

release notes

This issue or pull request should be mentioned in the release notes.

testing

This issue is related to testing the compiler, standard library, or other parts of Zig.

zig cc

Zig as a drop-in C-family compiler.

zig fmt

The Zig source code formatter.

zig reduce

The Zig source code reduction tool.

bounty

https://ziglang.org/news/announcing-donor-bounties

bug

Observed behavior contradicts documented or intended behavior.

contributor-friendly

This issue is limited in scope and/or knowledge of project internals.

downstream

An issue with a third-party project that uses this project.

enhancement

Solving this issue will likely involve adding new logic or components to the codebase.

infra

optimization

A task to improve performance and/or resource usage.

question

No questions on the issue tracker; use a community space instead.

regression

Something that used to work in a previous version stopped working

upstream

An issue with a third-party project that this project uses.

use case

Describes a real use case that is difficult or impossible, but does not propose a solution.

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ziglang/zig#31410

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?