ziglang/zig
262
6.0k
Fork
You've already forked zig
777

Implementing rint.c from libc in zig #31161

Manually merged
andrewrk merged 5 commits from kineye/zig:rint.c into master 2026年02月13日 06:42:58 +01:00
Contributor
Copy link

My first ziglang contribution. This was tested using the tests written for the rint function. Testing with the libc tests was not possible either due to user error or due to libc tests failing atm. They failed with and without my changes. Implements rint.c for libzigc #30978.

My first ziglang contribution. This was tested using the tests written for the rint function. Testing with the libc tests was not possible either due to user error or due to libc tests failing atm. They failed with and without my changes. Implements rint.c for libzigc #30978.
Merge remote-tracking branch 'upstream/master' into rint.c
Some checks failed
ci / x86_64-linux-debug (pull_request) Failing after 23m1s
ci / x86_64-freebsd-release (pull_request) Successful in 30m55s
ci / x86_64-netbsd-release (pull_request) Successful in 31m50s
ci / x86_64-freebsd-debug (pull_request) Successful in 36m34s
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ab76727cf6
kineye changed title from (削除) WIP implementing rint.c from libc in zig (削除ここまで) to Implementing rint.c from libc in zig 2026年02月09日 17:56:51 +01:00
lib/c/math.zig Outdated
@ -34,6 +34,7 @@ comptime {
@export(&nan,.{.name="nan",.linkage=common.linkage,.visibility=common.visibility});
@export(&nanf,.{.name="nanf",.linkage=common.linkage,.visibility=common.visibility});
@export(&nanl,.{.name="nanl",.linkage=common.linkage,.visibility=common.visibility});
@export(&rint,.{.name="__RINT",.linkage=common.linkage,.visibility=common.visibility});
Owner
Copy link
@export(&rint,.{.name="rint",.linkage=common.linkage,.visibility=common.visibility});

?

```zig @export(&rint, .{ .name = "rint", .linkage = common.linkage, .visibility = common.visibility }); ``` ?
Author
Contributor
Copy link

Fixed sorry that shouldn't be like that

Fixed sorry that shouldn't be like that
alexrp marked this conversation as resolved
fixed wrong export name
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 31m14s
ci / x86_64-netbsd-release (pull_request) Successful in 32m8s
ci / x86_64-windows-debug (pull_request) Successful in 35m35s
ci / x86_64-freebsd-debug (pull_request) Successful in 38m10s
ci / x86_64-windows-release (pull_request) Successful in 41m13s
ci / x86_64-openbsd-release (pull_request) Successful in 41m8s
ci / x86_64-netbsd-debug (pull_request) Successful in 43m0s
ci / aarch64-macos-release (pull_request) Successful in 47m25s
ci / x86_64-linux-debug (pull_request) Successful in 47m48s
ci / x86_64-openbsd-debug (pull_request) Successful in 55m44s
ci / aarch64-macos-debug (pull_request) Successful in 56m53s
ci / s390x-linux-release (pull_request) Successful in 1h17m42s
ci / aarch64-linux-release (pull_request) Successful in 1h27m9s
ci / x86_64-linux-release (pull_request) Failing after 1h29m18s
ci / s390x-linux-debug (pull_request) Successful in 2h4m45s
ci / powerpc64le-linux-release (pull_request) Successful in 1h39m55s
ci / aarch64-linux-debug (pull_request) Successful in 2h15m35s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 2h25m30s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h49m42s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
220a4fa281
lib/c/math.zig Outdated
@ -34,6 +34,7 @@ comptime {
@export(&nan,.{.name="nan",.linkage=common.linkage,.visibility=common.visibility});
@export(&nanf,.{.name="nanf",.linkage=common.linkage,.visibility=common.visibility});
@export(&nanl,.{.name="nanl",.linkage=common.linkage,.visibility=common.visibility});
@export(&rint,.{.name="rint",.linkage=common.linkage,.visibility=common.visibility});
Owner
Copy link

This should be moved into this block:

Lines 51 to 54 in 220a4fa
if(builtin.target.isMuslLibC()){
@export(&copysignf,.{.name="copysignf",.linkage=common.linkage,.visibility=common.visibility});
@export(&copysign,.{.name="copysign",.linkage=common.linkage,.visibility=common.visibility});
}
This should be moved into this block: https://codeberg.org/ziglang/zig/src/commit/220a4fa2816c075f120718c32f2e41c835c08e5e/lib/c/math.zig#L51-L54
alexrp marked this conversation as resolved
moving rint export to isMuslLibc target
All checks were successful
ci / x86_64-netbsd-release (pull_request) Successful in 34m40s
ci / aarch64-macos-release (pull_request) Successful in 34m54s
ci / x86_64-openbsd-release (pull_request) Successful in 37m59s
ci / x86_64-netbsd-debug (pull_request) Successful in 38m39s
ci / x86_64-freebsd-debug (pull_request) Successful in 38m36s
ci / x86_64-windows-release (pull_request) Successful in 42m7s
ci / aarch64-macos-debug (pull_request) Successful in 44m32s
ci / x86_64-openbsd-debug (pull_request) Successful in 51m53s
ci / x86_64-windows-debug (pull_request) Successful in 56m52s
ci / x86_64-freebsd-release (pull_request) Successful in 26m37s
ci / x86_64-linux-debug (pull_request) Successful in 1h15m30s
ci / aarch64-linux-release (pull_request) Successful in 1h26m28s
ci / s390x-linux-release (pull_request) Successful in 1h35m21s
ci / x86_64-linux-release (pull_request) Successful in 1h44m48s
ci / s390x-linux-debug (pull_request) Successful in 2h13m45s
ci / powerpc64le-linux-release (pull_request) Successful in 1h35m35s
ci / aarch64-linux-debug (pull_request) Successful in 2h31m42s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h27m4s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h52m23s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
e8b43f723d
Merge branch 'master' into rint.c
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-freebsd-release (pull_request) Successful in 31m28s
ci / x86_64-netbsd-release (pull_request) Successful in 32m0s
ci / aarch64-macos-release (pull_request) Successful in 35m58s
ci / x86_64-netbsd-debug (pull_request) Successful in 38m30s
ci / x86_64-freebsd-debug (pull_request) Successful in 38m13s
ci / x86_64-openbsd-release (pull_request) Successful in 43m41s
ci / x86_64-windows-release (pull_request) Successful in 45m55s
ci / x86_64-openbsd-debug (pull_request) Successful in 48m10s
ci / x86_64-linux-debug (pull_request) Successful in 48m49s
ci / x86_64-windows-debug (pull_request) Successful in 52m41s
ci / aarch64-macos-debug (pull_request) Successful in 59m33s
ci / s390x-linux-release (pull_request) Successful in 1h18m3s
ci / aarch64-linux-release (pull_request) Successful in 1h27m56s
ci / powerpc64le-linux-release (pull_request) Successful in 1h42m30s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h3m13s
ci / s390x-linux-debug (pull_request) Successful in 2h4m51s
ci / aarch64-linux-debug (pull_request) Successful in 2h16m0s
ci / x86_64-linux-release (pull_request) Successful in 2h26m14s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h23m15s
752c807e08

Needs a rebase to use the new symbol() helper.

Needs a rebase to use the new `symbol()` helper.
andrewrk manually merged commit f36d0573cd into master 2026年02月13日 06:42:58 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!31161
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "kineye/zig:rint.c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?