customize-mode compatibility #36

lolbinarycat commented 2020年10月04日 20:22:46 +02:00 (Migrated from github.com)

I typed customize-mode to add something to the hook, only to find that there wasn't one. Is there something I'm missing?

I typed `customize-mode` to add something to the hook, only to find that there wasn't one. Is there something I'm missing?

bbuccianti commented 2021年03月24日 19:29:02 +01:00 (Migrated from github.com)

I think would be useful to have a hook too. Would be trivial to add one like zig-mode-hook. If folks think this is doable, I can make a PR for that.

I think would be useful to have a hook too. Would be trivial to add one like zig-mode-hook. If folks think this is doable, I can make a PR for that.

jcs090218 commented 2024年02月21日 11:00:20 +01:00

zig-mode is using the standard define-derived-mode. The mode hook should be defined already. 🤔

`zig-mode` is using the standard `define-derived-mode`. The mode hook should be defined already. 🤔

lolbinarycat commented 2024年02月21日 18:44:54 +01:00 (Migrated from github.com)

if i had to guess it exists but isn't visible to custom.

if i had to guess it exists but isn't visible to `custom`.

jcs090218 commented 2024年02月21日 23:27:11 +01:00

What package management tool do you use to install packages? package.el? 🤔

What package management tool do you use to install packages? `package.el`? 🤔

lolbinarycat commented 2024年02月22日 00:06:05 +01:00 (Migrated from github.com)

yes.

it seems customize-mode is actually broken with a lot of non-core modes, i believe you need to add :group 'zig-mode to the mode definition.

yes. it seems `customize-mode` is actually broken with a lot of non-core modes, i believe you need to add `:group 'zig-mode` to the mode definition.

jcs090218 commented 2024年02月22日 01:12:27 +01:00

I believed is there for a long time, see

ziglang/zig-mode@9ce2009710/zig-mode.el (L494)

Apparently, customize mode can't work with unloaded module. Therefore, you have to (require 'zig-mode) before customize-mode.

I believed is there for a long time, see https://github.com/ziglang/zig-mode/blob/9ce200971008fa29641ab7bec80802b450b65646/zig-mode.el#L494 Apparently, customize mode can't work with unloaded module. Therefore, you have to `(require 'zig-mode)` before customize-mode.

ve-nt commented 2024年11月01日 23:58:43 +01:00 (Migrated from github.com)

I believed is there for a long time, see

ziglang/zig-mode@9ce2009710/zig-mode.el (L494)

Apparently, customize mode can't work with unloaded module. Therefore, you have to (require 'zig-mode) before customize-mode.

This doesn't appear to be the case on my setup. zig-mode-hook does not appear in the customize menu, despite being defined. I've created a PR (#113) that fixes this issue.

> I believed is there for a long time, see > > https://github.com/ziglang/zig-mode/blob/9ce200971008fa29641ab7bec80802b450b65646/zig-mode.el#L494 > > Apparently, customize mode can't work with unloaded module. Therefore, you have to `(require 'zig-mode)` before customize-mode. This doesn't appear to be the case on my setup. `zig-mode-hook` does not appear in the customize menu, despite being defined. I've created a PR (#113) that fixes this issue.