webxdc/editor
16
9
Fork
You've already forked editor
2

build: configure vite to target chrome 74 #42

Merged
r10s merged 1 commit from link2xt/target-chrome-74 into main 2023年08月12日 12:24:57 +02:00

The set of targets is the default for Vite,
but with chrome87 replaced with chrome74.

This is similar to the fix I had previously
to do in the XDC store: webxdc/store#27

The set of targets is the default for Vite, but with chrome87 replaced with chrome74. This is similar to the fix I had previously to do in the XDC store: https://codeberg.org/webxdc/store/pulls/27
The set of targets is the default for Vite,
but with chrome87 replaced with chrome74.
This is similar to the fix I had previously
to do in the XDC store: webxdc/store#27 
@ -2,2 +2,4 @@
export default defineConfig({
build: {
target: ['es2020', 'edge88', 'firefox78', 'chrome74', 'safari14'],
Owner
Copy link

Maybe it makes sense to also bump down edge since it's Chromium-based. Or to remove it, since webxdc apps don't run on Edge.

Maybe it makes sense to also bump down `edge` since it's Chromium-based. Or to remove it, since webxdc apps don't run on Edge.
Owner
Copy link

so, vite does some transpiling depending on these settings? and chose bad defaults?

anyways, moving that in as it fixes a concrete bug, thanks a lot!

so, vite does some transpiling depending on these settings? and chose bad defaults? anyways, moving that in as it fixes a concrete bug, thanks a lot!

so, vite does some transpiling depending on these settings? and chose bad defaults?

Not sure if you can call them bad, since it's us who are using new features, so we're responsible for that.

> so, vite does some transpiling depending on these settings? and chose bad defaults? Not sure if you can call them bad, since it's us who are using new features, so we're responsible for that.
rtn deleted branch link2xt/target-chrome-74 2023年09月22日 00:33:39 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!42
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "link2xt/target-chrome-74"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?