webxdc/editor
16
9
Fork
You've already forked editor
2

tweak toolbar ui #39

Merged
r10s merged 17 commits from tweak-ui into main 2023年08月12日 12:36:41 +02:00
Owner
Copy link
  • larger font in toolbar

  • align items in toolbar always vertically, using the full height (this is not always the case currently(

  • three headline level are enough

  • resort toolbar items: move undo/redo to menu or remove completely; paragraph-formatting should go right of character-formatting (as usual in virtually all editors); maybe hide dark-mode-switch; maybe more, that will be decided during the operation :)

  • do not indicate 'not allowed' or an 'error' if there is just nothing to save

  • (削除) make sure the save-button does not start a new line (still happens) (削除ここまで) out of scope of this pr, we only change sizes here

i'd still like to have the hamburger-icon a little bigger, however, that results in the dropdown menu being bigger as well - so, some larger changes are required. same for reworkd "Level 1" etc. to "Headline 1" ... sth. for another pr ... it is already complicated enough and somehow 90% close :)

CSS structure

  • div.ProseMirror-menubar
    • span.ProseMirror-menuitem
      • div.ProseMirror-menu-dropdown-wrap (hamburger menu, type menu)
        • div.ProseMirror-menu-dropdown
      • div.ProseMirror-icon (on active, class ProseMirror-menu-active is added)
        • svg
    • span.ProseMirror-menuseparator
- [x] larger font in toolbar - [x] align items in toolbar always vertically, using the full height (this is not always the case currently( - [x] three headline level are enough - [x] resort toolbar items: move undo/redo to menu or remove completely; paragraph-formatting should go right of character-formatting (as usual in virtually all editors); maybe hide dark-mode-switch; maybe more, that will be decided during the operation :) - [x] do not indicate 'not allowed' or an 'error' if there is just nothing to save - ~~make sure the save-button does not start a new line (still happens)~~ out of scope of this pr, we only change sizes here i'd still like to have the hamburger-icon a little bigger, however, that results in the dropdown menu being bigger as well - so, some larger changes are required. same for reworkd "Level 1" etc. to "Headline 1" ... sth. for another pr ... it is already complicated enough and somehow 90% close :) ## CSS structure - div.ProseMirror-**menubar** - span.ProseMirror-**menuitem** - div.ProseMirror-**menu-dropdown-wrap** (hamburger menu, type menu) - div.ProseMirror-**menu-dropdown** - div.ProseMirror-**icon** (on active, class ProseMirror-**menu-active** is added) - svg - span.ProseMirror-**menuseparator**
r10s changed title from (削除) WIP: tweak ui (削除ここまで) to tweak toolbar ui 2023年08月10日 23:00:01 +02:00
@ -91,0 +304,4 @@
.ProseMirror-menu-dropdown-item {
cursor: pointer;
padding: 12px 16px;
Owner
Copy link

FYI there is a thing that .ProseMirror-menu-dropdown-item is not the clickable thing, the clickable thing is its child. So if you click on the edge of .ProseMirror-menu-dropdown-item, nothing will happen. Maybe its better to increase the padding/margin of the child element (> * selector) instead of padding of this one.

FYI there is a thing that `.ProseMirror-menu-dropdown-item` is not the clickable thing, the clickable thing is its child. So if you click on the edge of `.ProseMirror-menu-dropdown-item`, nothing will happen. Maybe its better to increase the padding/margin of the child element (`> *` selector) instead of padding of this one.
Author
Owner
Copy link

maybe, however, the child seems to have the same size then. there seems to be no gaps in the dropdowns; this gets visible also if you add a border: 1px solid red; to .ProseMirror-menu-dropdown-item.

maybe i also misunderstood, so feel free to do a subsequent pr

maybe, however, the child seems to have the same size then. there seems to be no gaps in the dropdowns; this gets visible also if you add a `border: 1px solid red;` to `.ProseMirror-menu-dropdown-item`. maybe i also misunderstood, so feel free to do a subsequent pr
Author
Owner
Copy link

moving that in to move forward; we'll do a new release then, together with the fix of @link2xt at #42

moving that in to move forward; we'll do a new release then, together with the fix of @link2xt at https://codeberg.org/webxdc/editor/pulls/42
rtn deleted branch tweak-ui 2023年09月22日 00:33:26 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!39
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "tweak-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?