webxdc/editor
16
9
Fork
You've already forked editor
2

WIP: fix: iOS: toolbar getting scrolled out of view #32

Closed
WofWca wants to merge 1 commit from toolbar-position-sticky into main
pull from: toolbar-position-sticky
merge into: webxdc:main
webxdc:main
webxdc:tooling
webxdc:add-presence
webxdc:link2xt/autosave-interval-limit
webxdc:hpk/tryquill
webxdc:hpk/cleanup-indexhtml
webxdc:target-legacy
webxdc:inline-b64
webxdc:webxdc-x-web-version
webxdc:pages-demo
webxdc:status-string

Addresses #11

TODO:

  • This still doesn't fix it when the keyboard is open, based on @r10s 's tests.

IIRC I had a similar issue in one of my other projects, so maybe it's worth to google a bit.

Addresses #11 TODO: - [ ] This still doesn't fix it when the keyboard is open, based on @r10s 's tests. IIRC I had a similar issue in one of my other projects, so maybe it's worth to google a bit.
r10s closed this pull request 2023年08月12日 17:55:30 +02:00
@ -217,0 +219,4 @@
// https://codeberg.org/webxdc/editor/issues/11#issuecomment-993053)
// Why didn't the Prosemirror authors do the same? Because
// they wanted the menu to be sticky when the editor's element itself
// is getting scrolled by:
Author
Owner
Copy link

Actually I'm not sure now that it's true, because position: sticky also seems to work for this use case.

Actually I'm not sure now that it's true, because `position: sticky` also seems to work for this use case.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!32
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "toolbar-position-sticky"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?