• Joined on 2021年07月21日
ulexus created branch sean/go-1.23.1 in stagex/stagex 2024年09月17日 17:21:34 +02:00
ulexus pushed to sean/go-1.23.1 at stagex/stagex 2024年09月17日 17:21:34 +02:00
66455f3d33 packages/go: bump version to 1.23.1
ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

What is the purpose of this rewrite?

ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

Having this many path dereferences makes me nervous... the original implementation had separate forks to handle each directory case. While the original implementation essentially did the same thing (I think), the operations were semantically separated, providing at least a modicum of cover.

ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

nit: for simple error checking, it is more stable to use the if err := i.extractVersion(); err != nil {} syntax, because if you have a line of these otherwise, you will get shadow warnings from the linter, otherwise. It also makes it easier to move them around.

ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

Did this not throw an error for you? You shouldn't be able to name a method on the struct to the same name as a property on the same struct.

ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

Thankfully, we now have https://pkg.go.dev/slices#Contains which can replace this kind of special-purpose helper.

ulexus commented on pull request stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

See https://pkg.go.dev/net/url#Values.Add for a less string-manipulatey way of constructing these URLs.

ulexus approved stagex/sxctl#4 2024年03月10日 21:11:15 +01:00
WIP: feat: add vuln scanner

Good improvements; not much more to go

ulexus deleted branch lance/libqrencode from stagex/stagex 2024年03月09日 13:38:14 +01:00
ulexus merged pull request stagex/stagex#59 2024年03月09日 13:37:59 +01:00
feat: package libqrencode
ulexus pushed to staging at stagex/stagex 2024年03月09日 13:37:57 +01:00
798814c13a Merge branch 'lance/libqrencode' into staging
8600e7bec9 feat: package libqrencode
Compare 2 commits »
ulexus pushed to sean/regen-with-sxctl-0-0-5 at stagex/stagex 2024年03月09日 03:23:30 +01:00
e5c46850ee update sxctl to v0.0.5
ulexus created pull request stagex/stagex#62 2024年03月09日 03:19:41 +01:00
regenerate package.mk with new sxctl
ulexus created branch sean/regen-with-sxctl-0-0-5 in stagex/stagex 2024年03月09日 03:19:32 +01:00
ulexus pushed to sean/regen-with-sxctl-0-0-5 at stagex/stagex 2024年03月09日 03:19:32 +01:00
b312727561 regenerate package.mk with new sxctl
ulexus pushed tag v0.0.5 to stagex/sxctl 2024年03月09日 03:17:48 +01:00
ulexus commented on pull request stagex/sxctl#4 2024年03月09日 03:16:02 +01:00
WIP: feat: add vuln scanner

versions are frequently variously indicates, both with and without a v prefix:

  • v1.3.4
  • 1.3.4

When trying to parse such things, I tend to want to normalize to one or the other. In this...

ulexus closed pull request stagex/sxctl#6 2024年03月09日 03:13:11 +01:00
use stagex prefix instead of guesswork