toz/MediLog
9
51
Fork
You've already forked MediLog
3

Temperature Threshold Chart #537

Closed
opened 2025年07月08日 13:59:18 +02:00 by ybb40cxt · 7 comments
  1. My normal temperature runs lower then the 98.6°F (37°C) average. I adjusted the Thresholds accordingly.

  2. With a Rolling filter (2 Months in the attached screenshots, recorded temperatures removed) and Show Thresholds "on" the line for 98.1 is below the Title bar and 98.3 above (98.2 doesn't show).

  3. I'm guessing the plot centers around 98.6 which results in the graph and thresholds being on the top half of my screen? This would make sense and with the filter off it becomes a non-issue.

  4. Assuming 3 is correct. If possible, maybe plotting around the user average (Total) would better center on the screen no matter what filter is or isn't applied?

  5. If plotting on a user average is too complicated, perhaps just don't plot any Threshold above the Title bar?

  6. This is just a tiny observation, not really an issue.

1. My normal temperature runs lower then the 98.6°F (37°C) average. I adjusted the Thresholds accordingly. 2. With a Rolling filter (2 Months in the attached screenshots, recorded temperatures removed) and Show Thresholds "on" the line for 98.1 is below the Title bar and 98.3 above (98.2 doesn't show). 3. I'm guessing the plot centers around 98.6 which results in the graph and thresholds being on the top half of my screen? This would make sense and with the filter off it becomes a non-issue. 4. Assuming 3 is correct. If possible, maybe plotting around the user average (Total) would better center on the screen no matter what filter is or isn't applied? 5. If plotting on a user average is too complicated, perhaps just don't plot any Threshold above the Title bar? 6. This is just a tiny observation, _not really an **issue**._
Owner
Copy link

Above the title bar? :-)
Clearly a bug, is this with v2.7.x or the current beta?
Reason for asking is because I made some changes in this respect recently...haven't released it yet because I'd like for some more testing beforehand.

The way I decide on the top/bottom borders is that I capture the min and max values of the chart to be drawn. Add one degree buffer to both ends and draw. If the threshold is shown depends on whether the threshold value falls into the visible range.

While writing this I notice that the current approach to the buffer is flawed, I need to check what unit is used and use e.g. 1C and 10F as buffer?

Above the title bar? :-) Clearly a bug, is this with v2.7.x or the current beta? Reason for asking is because I made some changes in this respect recently...haven't released it yet because I'd like for some more testing beforehand. The way I decide on the top/bottom borders is that I capture the min and max values of the chart to be drawn. Add one degree buffer to both ends and draw. If the threshold is shown depends on whether the threshold value falls into the visible range. While writing this I notice that the current approach to the buffer is flawed, I need to check what unit is used and use e.g. 1C and 10F as buffer?

I am currently on the F-Droid version 3.2.7, build 5484.

I am currently on the F-Droid version 3.2.7, build 5484.
Owner
Copy link

I released v3.3.2 today, might take a few more days with F-Droid. Can you check if this issue still happens?
v3.3.2 comes with the revised approach to lower/bottom buffers, should be 10F for you.

I released v3.3.2 today, might take a few more days with F-Droid. Can you check if this issue still happens? v3.3.2 comes with the revised approach to lower/bottom buffers, should be 10F for you.

v3.3.2 released on 17 July became available on F-Droid today (25 July).

I think it is fixed but, the 10F buffer is too big? Maybe reduce to 2F?

I took before-after upgrade screenshots. The older version is easier to read; the newer version plots the threshold lines better.

v3.3.2 released on 17 July became available on F-Droid today (25 July). I think it is fixed but, the 10F buffer is too big? Maybe reduce to 2F? I took before-after upgrade screenshots. The older version is easier to read; the newer version plots the threshold lines better.
Owner
Copy link

Agree, will change to 2F. Also noticed the change in the grid, looked better previously in my opinion?

Agree, will change to 2F. Also noticed the change in the grid, looked better previously in my opinion?
toz added this to the 3.3.3 milestone 2025年07月25日 17:55:50 +02:00

@toz wrote in #537 (comment):

Also noticed the change in the grid, looked better previously in my opinion?

I liked the previous grid better as well.

@toz wrote in https://codeberg.org/toz/MediLog/issues/537#issuecomment-5988562: > Also noticed the change in the grid, looked better previously in my opinion? I liked the previous grid better as well.
Owner
Copy link

Fixed in v3.3.3

Fixed in v3.3.3
toz 2025年07月26日 10:47:51 +02:00
  • closed this issue
  • added the
    Done
    label
Sign in to join this conversation.
No Branch/Tag specified
main
3.6.0
3.3.8
master
v3.3.2
v3.2.7
v3.2.5
v3.2.1
v3.2.0
v3.1.2
v3.1.0
v3.0.7
v3.0.6
v3.0.5
v3.0.4
v2.7.4
v3.0.3
v3.0.1
v3.0.0
v2.7.3
v2.7.2
v2.7.1
v2.7.0
v2.6.3
v2.6.2
v2.6.0
v2.5.11
v2.5.10
v2.5.9
v2.5.8
v2.5.7
v2.5.6
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.8
v2.4.7
v2.4.6
v2.4.5
v2.4.4
v2.4.3
v2.4.2
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v3.7.1
v3.6.5
v3.6.4
v3.6.3
v3.6.2
v3.6.0
v3.5.1
v3.5.0
v3.4.1
v3.4.0
v3.3.11
v3.3.10
v3.3.9
v3.3.8
v3.3.7
v3.3.6
v3.3.5
v3.3.4
v3.3.3
v3.3.2
v3.2.7
v3.2.6
v3.2.5
v3.2.4
v3.2.3
v3.2.1
v3.2.0
v3.1.2
v3.1.1
v3.1.0
v3.0.7
v3.0.6
v3.0.5
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.7.3
v2.7.2
v2.7.1
v2.7.0
v2.6.3
v2.6.2
v2.6.1
v2.6.0
v2.5.11
v2.5.10
v2.5.9
v2.5.8
v2.5.7
v2.5.6
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.8
v2.4.7
v2.4.6
v2.4.5
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.5
v2.2.4
v2.2.3
v2.2.1
v2.2.2
v2.2.0
v2.1.2
v2.1.1
v2.1.0
v2.0.6
v2.0.5
v2.0.1
v3.7.0
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
toz/MediLog#537
Reference in a new issue
toz/MediLog
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?