1
2
Fork
You've already forked itemframes
2

[feature request] Add new nodes "Small Item Frame" and "Small Invisible Item Frame" #8

Closed
opened 2024年11月17日 00:51:28 +01:00 by rodrigo-morales · 1 comment

Consider this compact storage room (see screenshot below)

image

If the user decides to use Item Frames to label chests, the item frames cover the entire face of the chest, so the user can't right click on the chests to open the chests (see screenshot below)

image

One solution would be to use the Screwdriver to rotate the Item Frame. This way the user is able to right click the chest. A negative side this solution is that non-placeable blocks (e.g. Steel Ingot) can only be seen in one face of the Item Frame (see second screenshot below). Furthermore, users that build storage rooms with hundreds of chests would need to change the position of each Item Frame which might require significant amount of time.

image

image

Another solution would be to use use the block above the chest as the placeholder for the item frame. This way the user is able to right click the chest. A negative side of this solution is that an additional row above is required for each row of chests which is a limitation for those users that want to build compact storage rooms.

image

I believe we shouldn't change the size of the existing items itemframes:frame and itemframes:frame_invis, because doing so would disrupt the game for users that are already using this mod. Instead, I feel it would be great two new nodes are added to this mod: "Small Item Frame" and "Small Invisible Item Frame", they would have the same functionality of "Item Frame" and "Invisible Item Frame", respectively, but they would occupy 60% of the face of the block where they are placed on. This way users that place Item Frames on chests will still be able to open chests.

In the screenshot below, I was able to change the size of Item Frame by changing 0.5 to 0.35 in https://codeberg.org/tenplus1/itemframes/src/636acc7835d62d2b78dde1842147e8bef718b5b8/init.lua#L352-L357 (I modified itemframes:frame for demonstration purposes, as I mentioned earlier, I don't intend to modify the behavior of itemframes:frame because doing so would be disruptive for users that are already using this mod)

image

By having 2 new item frames: "Small Item Frame" and "Small Invisible Item Frame", this mod would satisfy more user needs and make Item Frames more useful to players.

Consider this compact storage room (see screenshot below) ![image](/attachments/d95b93df-1a4a-49b4-8f01-9ba6b7cbb2a7) If the user decides to use Item Frames to label chests, the item frames cover the entire face of the chest, so the user can't right click on the chests to open the chests (see screenshot below) ![image](/attachments/b588dd7b-1275-4f48-830a-f1634f5e6658) One solution would be to use the Screwdriver to rotate the Item Frame. This way the user is able to right click the chest. A negative side this solution is that non-placeable blocks (e.g. Steel Ingot) can only be seen in one face of the Item Frame (see second screenshot below). Furthermore, users that build storage rooms with hundreds of chests would need to change the position of each Item Frame which might require significant amount of time. ![image](/attachments/31ffcc46-a7c8-4c54-89ac-27083773b712) ![image](/attachments/3ffcd549-8aa6-4307-941b-471bf69ac428) Another solution would be to use use the block above the chest as the placeholder for the item frame. This way the user is able to right click the chest. A negative side of this solution is that an additional row above is required for each row of chests which is a limitation for those users that want to build compact storage rooms. ![image](/attachments/0552d854-c2f6-4028-97e2-4a5e39a4ec61) I believe we shouldn't change the size of the existing items `itemframes:frame` and `itemframes:frame_invis`, because doing so would disrupt the game for users that are already using this mod. Instead, I feel it would be great two new nodes are added to this mod: "Small Item Frame" and "Small Invisible Item Frame", they would have the same functionality of "Item Frame" and "Invisible Item Frame", respectively, but they would occupy 60% of the face of the block where they are placed on. This way users that place Item Frames on chests will still be able to open chests. In the screenshot below, I was able to change the size of Item Frame by changing 0.5 to 0.35 in https://codeberg.org/tenplus1/itemframes/src/636acc7835d62d2b78dde1842147e8bef718b5b8/init.lua#L352-L357 (I modified `itemframes:frame` for demonstration purposes, as I mentioned earlier, I don't intend to modify the behavior of `itemframes:frame` because doing so would be disruptive for users that are already using this mod) ![image](/attachments/2cd55864-6f6f-45dc-bf48-873cf133ead2) By having 2 new item frames: "Small Item Frame" and "Small Invisible Item Frame", this mod would satisfy more user needs and make Item Frames more useful to players.

I was meaning to shrink the itemframes by 1 pixel anyway, and also reduced selectionbox by 2 pixels so they look better and you can easily select the block behind them if it's a chest.

I was meaning to shrink the itemframes by 1 pixel anyway, and also reduced selectionbox by 2 pixels so they look better and you can easily select the block behind them if it's a chest.
Sign in to join this conversation.
No Branch/Tag specified
master
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tenplus1/itemframes#8
Reference in a new issue
tenplus1/itemframes
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?