removing duplicated entities can overshoot #5

tour-ist commented 2024年06月06日 00:25:10 +02:00

If you have 2 itemframes back to back, only one of them will show the item in it.

The reason is that the "remove duplicated entities"-implementation checks whether there is an itemframe entity in a distance of 0.5 nodes. But if you place your frames like shown in the image, the distance is only 1 - 2*6.5/16 = 0.19. So both entities count as duplicates and thus one is removed...

changing the radius here to 0.1 should do the trick

If you have 2 itemframes back to back, only one of them will show the item in it. The reason is that the "remove duplicated entities"-implementation checks whether there is an itemframe entity in a distance of 0.5 nodes. But if you place your frames like shown in the image, the distance is only `1 - 2*6.5/16 = 0.19`. So both entities count as duplicates and thus one is removed... changing the radius here to 0.1 should do the trick https://codeberg.org/tenplus1/itemframes/src/commit/3f249d1032c9c492849a9664b56fd3b07f65c3cc/init.lua#L27

tenplus1 commented 2024年06月06日 08:46:04 +02:00

Itemframes really shouldn't be that close together, and changing item radius to 0.1 affects frame updates causing glitches, so I'll leave it at 0.5 for now but look into making the redraw/update functions play nice.

Itemframes really shouldn't be that close together, and changing item radius to 0.1 affects frame updates causing glitches, so I'll leave it at 0.5 for now but look into making the redraw/update functions play nice.

whosit commented 2024年12月03日 18:51:44 +01:00

Here's an illustration of the "overshooting" issue:
itemframe_vizlib
itemframe_item

It happens because the center argument of get_objects_inside_radius() is set to the item's center, not to the center of the node.

If you just round the position with vector.round() like this:

		local pos = self.object:get_pos() ; if not pos then return end
		local node_pos = vector.round(pos) 
		
		-- vizlib.draw_cube(pos, 0.5, {color = "red"})
		-- vizlib.draw_cube(node_pos, 0.5, {color = "green"})
		
		local objs = minetest.get_objects_inside_radius(node_pos, 0.5)

where items are removed and entity position is used: in on_activate and in remove_item, the issue will be gone :)
(lbm actually uses node coordinates and does not seem to need rounding)

Here's an illustration of the "overshooting" issue:   It happens because the `center` argument of `get_objects_inside_radius()` is set to the item's center, not to the center of the node. If you just round the position with `vector.round()` like this: ```lua local pos = self.object:get_pos() ; if not pos then return end local node_pos = vector.round(pos) -- vizlib.draw_cube(pos, 0.5, {color = "red"}) -- vizlib.draw_cube(node_pos, 0.5, {color = "green"}) local objs = minetest.get_objects_inside_radius(node_pos, 0.5) ``` where items are removed and entity position is used: in `on_activate` and in `remove_item`, the issue will be gone :) (lbm actually uses node coordinates and does not seem to need rounding)

tenplus1 commented 2024年12月04日 09:37:34 +01:00

Updated with new removal function, works fine my end, please let me know if ok yours :)

Updated with new removal function, works fine my end, please let me know if ok yours :)

whosit commented 2024年12月04日 21:05:59 +01:00

screenshot_20241204_230252
Seems to work, weirdness is possible again. Thank you :)

 Seems to work, weirdness is possible again. Thank you :)