frost_ocean and other biomes not fixed #7

Bastrabun commented 2024年01月26日 03:55:59 +01:00

Unfortunately #2 it is not fixed. The biome frost_ocean now starts at -0, which is 2 blocks below the surface. First air block above ocean is at y=2.

The fix

109a749bb3

moved the biome one LOWER instead of higher.

The bobber's position is around y=1.5

I suggest you include at least y=2, maybe even y=3

For my reference 5716

Unfortunately #2 it is not fixed. The biome frost_ocean now starts at -0, which is 2 blocks below the surface. First air block above ocean is at y=2. The fix https://codeberg.org/tenplus1/ethereal/commit/109a749bb393d60d689f815a4c801808d7f034f4 moved the biome one LOWER instead of higher. The bobber's position is around y=1.5 I suggest you include at least y=2, maybe even y=3 For my reference 5716

tenplus1 commented 2024年01月26日 09:39:35 +01:00

I've tweaked the *_ocean values to be 2 at highest point, also lowered bobber position value to be in water itself when catching something :)

I've tweaked the *_ocean values to be 2 at highest point, also lowered bobber position value to be in water itself when catching something :)

Bastrabun commented 2024年01月27日 01:38:30 +01:00

Now somehow frost biomes have coniferous forest ocean?

add_biome("coniferous_forest_ocean", -192, 2, 10, 40, ethereal.snowy,
add_biome("frost_ocean", -192, 2, 10, 40, ethereal.frost,

Now somehow frost biomes have coniferous forest ocean? ``` add_biome("coniferous_forest_ocean", -192, 2, 10, 40, ethereal.snowy, add_biome("frost_ocean", -192, 2, 10, 40, ethereal.frost, ```

tenplus1 commented 2024年01月27日 08:57:16 +01:00

Tweaked frost biome to be lower layer of coniferous, fixed fishing check.

Tweaked frost biome to be lower layer of coniferous, fixed fishing check.

Bastrabun commented 2024年01月28日 14:43:23 +01:00

Now somehow frost biomes have taiga ocean?

Now somehow frost biomes have taiga ocean?

tenplus1 commented 2024年01月28日 15:56:54 +01:00

That was a leftover copy/paste that wasnt required, has been removed.

That was a leftover copy/paste that wasnt required, has been removed.

Bastrabun commented 2024年01月28日 17:30:09 +01:00

How would fishing ethereal:fish_mackerel work? In a cave under the ocean it does work, but that can't be the plan? :D:D:D

{"ethereal:fish_mackerel", "glacier_ocean"}
minetest.register_biome({
	name = "glacier_ocean",
	node_dust = "default:snowblock",
	node_top = "default:sand",
	depth_top = 1,
	node_filler = "default:sand",
	depth_filler = 3,
	y_min = -112,
	y_max = -9, <--- ??
	heat_point = 0,
	humidity_point = 50
})

Could you please go through all the biomes and fishes and see whether they make sense? :P

waves a fishing rod in the most menacing way

How would fishing ethereal:fish_mackerel work? In a cave under the ocean it does work, but that can't be the plan? :D:D:D {"ethereal:fish_mackerel", "glacier_ocean"} minetest.register_biome({ name = "glacier_ocean", node_dust = "default:snowblock", node_top = "default:sand", depth_top = 1, node_filler = "default:sand", depth_filler = 3, y_min = -112, y_max = -9, <--- ?? heat_point = 0, humidity_point = 50 }) Could you please go through all the biomes and fishes and see whether they make sense? :P *waves a fishing rod in the most menacing way*

tenplus1 commented 2024年01月28日 18:21:16 +01:00

Good question, that should have been "glacier" :) fixed

Good question, that should have been "glacier" :) fixed