pr create crashes when branch has no tracking remote #46

stalecontext commented 2026年03月31日 02:17:48 +02:00

Bug

fj pr create crashes with a git2 config error when the current branch does not have a tracking remote configured, even when repo detection succeeds via other means (e.g., the origin fallback from #44).

Error

Error: config value 'branch.<name>.remote' was not found; class=Config (7); code=NotFound (-3)
Location:
 src\prs.rs:941:31

Steps to reproduce

git checkout -b new-branch # no upstream tracking
git push origin new-branch # push without -u (or -u fails to set tracking)
fj pr create "Title" --base main
# Error: config value 'branch.new-branch.remote' was not found

Expected behavior

fj pr create should fall back to the resolved remote from RepoInfo::get_current() (or to origin) when the branch has no tracking remote, rather than crashing.

Workaround

Set tracking manually before creating the PR:

git branch --set-upstream-to=origin/new-branch
fj pr create "Title" --base main

Location

src/prs.rs:941 -- reads branch.<name>.remote from git config without handling the not-found case.

## Bug `fj pr create` crashes with a git2 config error when the current branch does not have a tracking remote configured, even when repo detection succeeds via other means (e.g., the origin fallback from #44). ### Error ``` Error: config value 'branch.<name>.remote' was not found; class=Config (7); code=NotFound (-3) Location: src\prs.rs:941:31 ``` ### Steps to reproduce ```sh git checkout -b new-branch # no upstream tracking git push origin new-branch # push without -u (or -u fails to set tracking) fj pr create "Title" --base main # Error: config value 'branch.new-branch.remote' was not found ``` ### Expected behavior `fj pr create` should fall back to the resolved remote from `RepoInfo::get_current()` (or to `origin`) when the branch has no tracking remote, rather than crashing. ### Workaround Set tracking manually before creating the PR: ```sh git branch --set-upstream-to=origin/new-branch fj pr create "Title" --base main ``` ### Location `src/prs.rs:941` -- reads `branch.<name>.remote` from git config without handling the not-found case.