3
0
Fork
You've already forked frontend
0

feat: edit profile #5

Merged
EmmaTech merged 11 commits from :feat/edit-profile into main 2025年01月09日 05:36:30 +01:00

<video src="https://codeberg.org/attachments/b7e1e616-c070-49db-a13f-a95eeb4c8ac6" width="700" height="700" controls></video>
EmmaTech requested changes 2025年01月09日 01:00:24 +01:00
Dismissed
EmmaTech left a comment
Copy link

otherwise, looks awesome! I'm impressed with how it turns out :o

otherwise, looks awesome! I'm impressed with how it turns out :o
@ -37,6 +48,12 @@
<!--avatar used to be here-->
<div class="flex flex-row-reverse p-2 gap-2">
{#if $sessionData && user.id === $sessionData.user.id}
Owner
Copy link

I would move this under the follower button, I don't like having the ellipsis button being first

I would move this under the follower button, I don't like having the ellipsis button being first
ananas marked this conversation as resolved
@ -38,2 +49,4 @@
<div class="flex flex-row-reverse p-2 gap-2">
{#if $sessionData && user.id === $sessionData.user.id}
<button onclick={withPreventDefault(() => editProfile = true)} class="text-gray-300 hover:bg-gray-400 transition-colors px-2 rounded-full">
Owner
Copy link

the style with no background looks a bit out of place, I would recommend using text-gray-300 bg-slate-500 hover:bg-slate-600 to match the follow/unfollow buttons a bit more instead.

the style with no background looks a bit out of place, I would recommend using `text-gray-300 bg-slate-500 hover:bg-slate-600` to match the follow/unfollow buttons a bit more instead.
ananas marked this conversation as resolved
@ -39,1 +50,4 @@
<div class="flex flex-row-reverse p-2 gap-2">
{#if $sessionData && user.id === $sessionData.user.id}
<button onclick={withPreventDefault(() => editProfile = true)} class="text-gray-300 hover:bg-gray-400 transition-colors px-2 rounded-full">
<h1>Edit Profile</h1>
Owner
Copy link

<p class="text-sm"> instead

`<p class="text-sm">` instead
ananas marked this conversation as resolved
EmmaTech left a comment
Copy link

looks good :3

looks good :3
EmmaTech referenced this pull request from a commit 2025年01月09日 05:36:32 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
soteria/frontend!5
Reference in a new issue
soteria/frontend
No description provided.
Delete branch ":feat/edit-profile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?