Compilation error on Zig master after a0a2ce9 #205

NyanCatTW1 commented 2022年06月26日 11:05:06 +02:00 (Migrated from code.blicky.net)

When I tried to build the latest ncdu version (058b26bf9a), the following error occured:

./src/main.zig:345:38: error: expected error union type, found 'std.child_process.ChildProcess'
 var child = std.ChildProcess.init(&.{shell}, allocator) catch unreachable;

It's due to commit a0a2ce9, which quote "std: Do not allocate the result for ChildProcess.init"
A patch is provided that will hopefully still work by the time of the Zig 0.10 release.

When I tried to build the latest ncdu version (058b26bf9a), the following error occured: ``` ./src/main.zig:345:38: error: expected error union type, found 'std.child_process.ChildProcess' var child = std.ChildProcess.init(&.{shell}, allocator) catch unreachable; ``` It's due to commit a0a2ce9, which quote "std: Do not allocate the result for ChildProcess.init" A patch is provided that will hopefully still work by the time of the Zig 0.10 release.

yorhel commented 2022年06月26日 11:07:45 +02:00 (Migrated from code.blicky.net)

No need, I'll upgrade to latest Zig when 0.10 comes out. Keeping up with changes on master before that is usually not worth the effort.

No need, I'll upgrade to latest Zig when 0.10 comes out. Keeping up with changes on master before that is usually not worth the effort.

NyanCatTW1 commented 2022年06月26日 11:09:40 +02:00 (Migrated from code.blicky.net)

Thanks for the fast reply! Guess it's still worth it to figure out the fix early though? Or is zig fmt capable of patching it automatically by the time of release?

Thanks for the fast reply! Guess it's still worth it to figure out the fix early though? Or is `zig fmt` capable of patching it automatically by the time of release?

yorhel commented 2022年06月26日 11:18:34 +02:00 (Migrated from code.blicky.net)

It's a manual process, but the reason I don't fix these early on is because the fixes will often break compatibility with stable Zig. If course, if there's an easy fix that works across both stable and master Zig I'll be happy to apply it anyway, but in general I don't put much effort in supporting master, given how unstable it is.

It's a manual process, but the reason I don't fix these early on is because the fixes will often break compatibility with stable Zig. If course, if there's an easy fix that works across both stable and master Zig I'll be happy to apply it anyway, but in general I don't put much effort in supporting master, given how unstable it is.

NyanCatTW1 commented 2022年06月26日 11:20:07 +02:00 (Migrated from code.blicky.net)

My current plan is just to figure out the patch, so that by the time the update comes out, it will be as simple as applying the patch.
That is, if the std library doesn't change again in a breaking way before that...

My current plan is just to figure out the patch, so that by the time the update comes out, it will be as simple as applying the patch. That is, if the std library doesn't change again in a breaking way before that...

NyanCatTW1 commented 2022年06月26日 11:33:52 +02:00 (Migrated from code.blicky.net)

Got it! Unfortunately it will break compatibility with stable Zig. I'll just put the patch here and wait for it to hopefully become useful once the 0.10 release comes out.

Got it! Unfortunately it will break compatibility with stable Zig. I'll just put the patch here and wait for it to hopefully become useful once the 0.10 release comes out.

yorhel commented 2022年11月01日 08:49:22 +01:00 (Migrated from code.blicky.net)

0.10.0 is out, I'll post status and updates in #213

0.10.0 is out, I'll post status and updates in #213