Show the overview filter summary only when filters are active #60

systemblue commented 2026年06月03日 00:54:59 +02:00

What

The Issues and Pull Requests overviews pinned a centered filter-summary caption ("Open") below the title even in the default state, which just duplicated the filter icon. Now the summary appears only when a non-default state or involvement scope is active, so the default view carries no extra chrome and the strip becomes a clear signal that the list is filtered.

Verified in the iPhone 17 Pro simulator: default state shows no strip and no gap, and the filter icon still reflects state. Builds clean on Xcode 26, SwiftLint passes.

---

I grant Stefan Hausotte an irrevocable, worldwide, royalty-free license to use, sublicense, and distribute my contribution, including through Apple's App Store under the project's App Store exception.

## What The Issues and Pull Requests overviews pinned a centered filter-summary caption ("Open") below the title even in the default state, which just duplicated the filter icon. Now the summary appears only when a non-default state or involvement scope is active, so the default view carries no extra chrome and the strip becomes a clear signal that the list is filtered. Verified in the iPhone 17 Pro simulator: default state shows no strip and no gap, and the filter icon still reflects state. Builds clean on Xcode 26, SwiftLint passes. --- I grant Stefan Hausotte an irrevocable, worldwide, royalty-free license to use, sublicense, and distribute my contribution, including through Apple's App Store under the project's App Store exception.

secana commented 2026年06月04日 13:04:06 +02:00

Thanks! The change itself is good, but it breaks two UI tests that assert the
filter summary shows "Open" in the default state, which this PR now hides:

• IssueUITests.testIssuesOverviewInvolvementFilter
• PullRequestUITests.testPullRequestsOverviewInvolvementFilter

Please update both to assert the summary is absent in the default state and
appears once a non-default scope (e.g. "Assigned to you") is selected, then run
just test-ui to confirm green. Happy to merge after that.

Thanks! The change itself is good, but it breaks two UI tests that assert the filter summary shows "Open" in the default state, which this PR now hides: - IssueUITests.testIssuesOverviewInvolvementFilter - PullRequestUITests.testPullRequestsOverviewInvolvementFilter Please update both to assert the summary is absent in the default state and appears once a non-default scope (e.g. "Assigned to you") is selected, then run `just test-ui` to confirm green. Happy to merge after that.