raboof/volare
6
22
Fork
You've already forked volare
2

Mod+x misbehaving #77

Open
opened 2024年02月21日 00:26:19 +01:00 by raboof · 5 comments

I don't have a good reproducible testcase available right now, but it seems Mod+x behavior isn't always behaving well. To look into.

I don't have a good reproducible testcase available right now, but it seems Mod+x behavior isn't always behaving well. To look into.
Author
Owner
Copy link

I had a scenario where:

  • top-level split vertically
  • left split in three horizontally
  • bottom split vertically
  • right side tabbed

Hitting mod+x on the 'middle' of the 3 horizontally split frames led to a spurious header over the H[T[x] T[x x x x]]

I had a scenario where: * top-level split vertically * left split in three horizontally * bottom split vertically * right side tabbed Hitting mod+x on the 'middle' of the 3 horizontally split frames led to a spurious header over the H[T[x] T[x x x x]]
Collaborator
Copy link

What do you have Mod+x bound to?

What do you have Mod+x bound to?
Author
Owner
Copy link

split none (aka unsplit)

`split none` (aka unsplit)
Author
Owner
Copy link

Hrm it seems I was using 'horizontally'/'vertically' differently from Sway: apparently sway calls two windows that are next to each other 'horizontally split' and windows that are above/under each other 'vertically split'. I guess we should follow that (though it's counter-intuitive to me).

recipe for reproducing:

  • start volare
  • split horizontally
  • unsplit
  • split horizontally
  • split the left side vertically
  • mod+x the right side

This leaves a situation where the 'top-level' vertically split window has a titlebar (showing 'V[T[] T[]]'), but both split windows as well (showing nothing). Also, Mod+w no longer 'wraps around' correctly.

Hrm it seems I was using 'horizontally'/'vertically' differently from Sway: apparently sway calls two windows that are next to each other 'horizontally split' and windows that are above/under each other 'vertically split'. I guess we should follow that (though it's counter-intuitive to me). recipe for reproducing: * start volare * split horizontally * unsplit * split horizontally * split the left side vertically * mod+x the right side This leaves a situation where the 'top-level' vertically split window has a titlebar (showing 'V[T[<empty>] T[<empty>]]'), but both split windows as well (showing nothing). Also, Mod+w no longer 'wraps around' correctly.
Author
Owner
Copy link

Another error case (perhaps we'll have to split this issue...):

  • start volare
  • split vertically
  • split vertically
  • start terminals on all 3 tiles
  • unsplit the bottom tile

I think what we'd want to happen in this case is that the top tile remains as-is, and a tabbed container is introduced to hold the bottom two terminals. Instead, the bottom terminal is added to the top-level vertical split.

Another error case (perhaps we'll have to split this issue...): * start volare * split vertically * split vertically * start terminals on all 3 tiles * unsplit the bottom tile I think what we'd want to happen in this case is that the top tile remains as-is, and a tabbed container is introduced to hold the bottom two terminals. Instead, the bottom terminal is added to the top-level vertical split.
Sign in to join this conversation.
No Branch/Tag specified
main
prepare-for-1.11
volare-1.10
multi-system
prepare-for-0.10
volare-1.9
fix-config-examples
prepare-for-1.9
rebase-on-1.9
volare-1.8.0.x
fix-ci
test
config
flake-enable-debugging
avoid_unsplit_crash
move
move-tab-config-syntax
move-tab
implement-unsplit
build-on-ci
versioning
sway-replacement-non-goal
document-branching-strategy
drop-issue-templates
look
wallpaper
renames
remove-toggle-split
update-to-1.8
update-to-1.8-branch-off-point
unsplit
second_test
v1.11.0.0
v1.10.1.0
1.10.1
1.10
1.10-rc4
1.10-rc3
1.10-rc2
1.10-rc1
v1.9.0.0
1.9
1.9-rc4
1.9-rc3
1.9-rc2
1.9-rc1
v1.8.1.0
1.8.1
1.8
1.8-rc4
1.8-rc3
1.8-rc2
1.8-rc1
1.7
1.7-rc3
1.7-rc2
1.7-rc1
1.6.1
1.6
1.6-rc3
1.6-rc2
1.6-rc1
1.5.1
1.5
v1.5-rc2
1.5-rc1
1.4
1.3-rc3
1.3-rc2
1.3-rc1
1.2
1.2-rc2
1.2-rc1
1.1.1
1.1
1.1-rc3
1.1-rc2
1.1-rc1
1.0
1.0-rc5
1.0-rc4
1.0-rc3
1.0-rc2
1.0-rc1
1.0-beta.2
1.0-beta.1
1.0-alpha.6
1.0-alpha.5
1.0-alpha.4
1.0-alpha.3
1.0-alpha.2
1.0-alpha.1
0.15-rc1
0.14-rc1
0.13-rc1
0.12-rc1
0.11
0.11-rc3
0.11-rc2
0.11-rc1
0.10-rc1
0.9
0.9-rc3
0.9-rc2
0.9-rc1
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
raboof/volare#77
Reference in a new issue
raboof/volare
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?