Dragging a tab to 'its own' frame makes it disappear #42

raboof commented 2023年06月08日 14:09:18 +02:00

When I use the mouse to drag a window by its tab, but instead of dropping it in a different frame I drop it in the frame where it already is, it disappears.

When I use the mouse to drag a window by its tab, but instead of dropping it in a different frame I drop it in the frame where it already is, it disappears.

edmonds commented 2023年06月08日 18:23:58 +02:00

I tried to replicate this but couldn't. Any further details, or anything interesting in the logging output when running with --debug? Does it happen all the time? Any other windows in the same frame, or other frames? Is the tabbed container inside another split container?

Output of swaymsg -t get_workspaces before/after might be helpful, also volare --version (shows the git commit/branch name).

If it's replicable, I would guess the function handle_motion_postthreshold() in sway/input/seatop_move_tiling.c might be implicated. There were a couple of commits changing the behavior of that function in the empty tabbed containers PR, a1385310c and 4d4611f80. There might be another corner case that we need to handle in that function, or those added conditions need to be refined. We might need an explicit check that the container being dragged is not the same as the node under the mouse cursor, or something like that.

I tried to replicate this but couldn't. Any further details, or anything interesting in the logging output when running with `--debug`? Does it happen all the time? Any other windows in the same frame, or other frames? Is the tabbed container inside another split container? Output of `swaymsg -t get_workspaces` before/after might be helpful, also `volare --version` (shows the git commit/branch name). If it's replicable, I would guess the function `handle_motion_postthreshold()` in `sway/input/seatop_move_tiling.c` might be implicated. There were a couple of commits changing the behavior of that function in the empty tabbed containers PR, a1385310c and 4d4611f80. There might be another corner case that we need to handle in that function, or those added conditions need to be refined. We might need an explicit check that the container being dragged is not the same as the node under the mouse cursor, or something like that.

edmonds commented 2023年06月09日 06:28:20 +02:00

The first commit in #43 should fix this, and the second commit shouldn't hurt.

The first commit in #43 should fix this, and the second commit shouldn't hurt.

raboof commented 2023年06月09日 08:37:22 +02:00

also volare --version (shows the git commit/branch name).

Hmm, it doesn't for me - perhaps because I'm building as a Nix flake? Filed #44

> also `volare --version` (shows the git commit/branch name). Hmm, it doesn't for me - perhaps because I'm building as a Nix flake? Filed #44