[Bug] please link with libz at least on GNU/Linux #13

positron commented 2023年03月22日 17:51:01 +01:00 (Migrated from gitea.pep.foundation)

I have started again using the Python adapter with recent Engines, on my GNU/Linux system.

This is about Python adapter v3.2.0-RC1.

The adapter seems to build and install correctly, but I see a failure at run time as soon as I try to load the pEp module from Python:

undefined symbol: inflate

This is simply related to a missing dynamic library; who knows what caused the dependency chain to change. Anyway, linking with -lz solves the problem and should be completely harmless anywhere.

Observed behaviour: unresolved symbol when the dynamic library is loaded
Expected behaviour: successful dynamic library loading

I suggest the following change, which solves the problem for me:

diff --git a/setup.py b/setup.py
index 94e8637..57d793e 100755
--- a/setup.py
+++ b/setup.py
@@ -125,7 +125,8 @@ class BuildExtCommand(build_ext):
 'pEpAdapter',
 'pEpCxx11',
 'boost_python3',
- 'boost_locale'
+ 'boost_locale',
+ 'z'
 ]
 compile_flags = ['-std=c++14', '-fpermissive']
 if self.debug:

I have started again using the Python adapter with recent Engines, on my GNU/Linux system. This is about Python adapter `v3.2.0-RC1`. The adapter seems to build and install correctly, but I see a failure at run time as soon as I try to load the pEp module from Python: undefined symbol: inflate This is simply related to a missing dynamic library; who knows what caused the dependency chain to change. Anyway, linking with `-lz` solves the problem and should be completely harmless anywhere. Observed behaviour: unresolved symbol when the dynamic library is loaded Expected behaviour: successful dynamic library loading I suggest the following change, which solves the problem for me: diff --git a/setup.py b/setup.py index 94e8637..57d793e 100755 --- a/setup.py +++ b/setup.py @@ -125,7 +125,8 @@ class BuildExtCommand(build_ext): 'pEpAdapter', 'pEpCxx11', 'boost_python3', - 'boost_locale' + 'boost_locale', + 'z' ] compile_flags = ['-std=c++14', '-fpermissive'] if self.debug:

heck commented 2023年03月22日 18:40:00 +01:00 (Migrated from gitea.pep.foundation)

Fixed as part of: https://gitea.pep.foundation/pEp.foundation/pEpPythonAdapter/releases/tag/v3.2.0-RC2

(could not test, though because i dont have a linux VM currently)

Fixed as part of: https://gitea.pep.foundation/pEp.foundation/pEpPythonAdapter/releases/tag/v3.2.0-RC2 (could not test, though because i dont have a linux VM currently)