feat: add strategy #1

pat-s commented 2026年06月26日 15:57:14 +02:00

Currently strategy is undefined, which leads to RollingUpdate. This is an issue for single-replica deployments and will result in a deadlock when the pod gets provisoned to a new node and uses a RWO volume.

It might also be good to default to Recreate then.

Currently `strategy` is undefined, which leads to `RollingUpdate`. This is an issue for single-replica deployments and will result in a deadlock when the pod gets provisoned to a new node and uses a RWO volume. It might also be good to default to `Recreate` then.

jessebot commented 2026年06月27日 12:18:43 +02:00

Added a strategyType in 0.4.0 to help with this! Give it a shot and let me know if it works 🙏

Added a `strategyType` in `0.4.0` to help with this! Give it a shot and let me know if it works 🙏

pat-s commented 2026年06月27日 21:04:20 +02:00

Thanks - but there's a indent definition error that prevents the chart render. strategy should be below spec, not template.

Some basic render or general unit tests could to prevent these in the future.

Thanks - but there's a indent definition error that prevents the chart render. `strategy` should be below `spec`, not `template`. Some basic render or general unit tests could to prevent these in the future.

jessebot commented 2026年06月28日 12:09:19 +02:00

Thanks - but there's a indent definition error that prevents the chart render. strategy should be below spec, not template.

oof, yeah, let me fix that.

Some basic render or general unit tests could to prevent these in the future.

It passed the helm template and helm lint, however we haven't setup a full chart testing action yet since migrating from github. It's on our list!

> Thanks - but there's a indent definition error that prevents the chart render. strategy should be below spec, not template. oof, yeah, let me fix that. > Some basic render or general unit tests could to prevent these in the future. It passed the `helm template` and `helm lint`, however we haven't setup a full chart testing action yet since migrating from github. It's on our list!

jessebot commented 2026年06月28日 12:21:39 +02:00

Give 0.5.1 a shot now :)

Give `0.5.1` a shot now :)

pat-s commented 2026年06月29日 00:24:57 +02:00

Works now!

Works now!