3
2
Fork
You've already forked timecheck
5

Grammatical and orthographic mistakes #31

Closed
opened 2021年04月02日 12:36:23 +02:00 by PeaceOfBread · 6 comments

I found some mistakes in the English configuration of Timecheck (the configuration after one does ./install-timecheck):

  1. The first screen says "[...] if it does not existing yet. [...]", but the right spelling would be "[...] if it does not exist yet. [...]" (existing to exist).
  2. The second screen says "Timecheck konfiguration" in the title, but it should be "Timecheck configuration" (konfiguration to configuration).
  3. The screen that let's one check if all information is correct says "[...] Are these information correct? [...]", but the grammaticaly correct version would be [...] Is this information correct? [...] (Are these to Is this).
  4. The last message in the terminal has some things I'd correct or phrase differently:
    --1: "[...] We are almost done. Just one thing is missing [...]" should be "[...] We are almost done. There is just one thing missing. [...]" (the there (with a minor adjustion of the sentence) and the dot at the sentence's end are added).
    --2: "[...] Please add the following to the end of the root crontab
    open the crontab with 'sudo crontab -e' [...]" should be switched and corrected a bit to "[...] Open the crontab with 'sudo crontab -e'
    Please add the following to the end of the root crontab:" (switched the two sentences, made open to Open, added : at the end).
    --3: "[...] if you want to change the configuration please run [...]" should be "[...] If you want to change the configuration please run the following: [...]" (if to If, added the following, added : at the end).
    (--3.5: Question: Is the in "change-settings.sh in /opt/timecheck/" part of the command?)
    --4: "[...] You may also edit timecheck.conf by your own
    but this is not recommended! [...]" should be "[...] You may also edit timecheck.conf by your own.
    But this is not recommended! [...]" (dot at end of first sentence, but to But).

Also, there is a mistake in the German README: It says the terminal command "chomod +x install-timecheck.sh" but it should be, like in the English README: "chmod +x install-timecheck.sh" (chomod to chmod)

That was a lot of things xD, but that’s it.

Thanks for the great script anyways! :)

I found some mistakes in the English configuration of Timecheck (the configuration after one does ./install-timecheck): 1) The first screen says "[...] if it does not existing yet. [...]", but the right spelling would be "[...] if it does not exist yet. [...]" **(existing to exist)**. 2) The second screen says "Timecheck konfiguration" in the title, but it should be "Timecheck configuration" **(konfiguration to configuration)**. 3) The screen that let's one check if all information is correct says "[...] Are these information correct? [...]", but the grammaticaly correct version would be [...] Is this information correct? [...] **(Are these to Is this)**. 4) The last message in the terminal has some things I'd correct or phrase differently: --1: "[...] We are almost done. Just one thing is missing [...]" should be "[...] We are almost done. There is just one thing missing. [...]" **(the there (with a minor adjustion of the sentence) and the dot at the sentence's end are added)**. --2: "[...] Please add the following to the end of the root crontab open the crontab with 'sudo crontab -e' [...]" should be switched and corrected a bit to "[...] Open the crontab with 'sudo crontab -e' Please add the following to the end of the root crontab:" **(switched the two sentences, made open to Open, added : at the end)**. --3: "[...] if you want to change the configuration please run [...]" should be "[...] If you want to change the configuration please run the following: [...]" **(if to If, added the following, added : at the end)**. (--3.5: Question: Is the in "change-settings.sh in /opt/timecheck/" part of the command?) --4: "[...] You may also edit timecheck.conf by your own but this is not recommended! [...]" should be "[...] You may also edit timecheck.conf by your own. But this is not recommended! [...]" **(dot at end of first sentence, but to But)**. Also, there is a mistake in the German README: It says the terminal command "chomod +x install-timecheck.sh" but it should be, like in the English README: "chmod +x install-timecheck.sh" (chomod to chmod) That was a lot of things xD, but that’s it. Thanks for the great script anyways! :)
PeaceOfBread changed title from (削除) Mistake in the English configuration screens (削除ここまで) to Grammarical mistakes in the English configuration 2021年04月02日 12:37:37 +02:00
PeaceOfBread changed title from (削除) Grammarical mistakes in the English configuration (削除ここまで) to Grammatical and orthographic mistakes 2021年04月02日 14:12:32 +02:00
Collaborator
Copy link

Should be fixed in !32. Could you take a look on it?

Should be fixed in !32. Could you take a look on it?

Thanks j.r! I am comletely new to this Git-terry, so I first need to understand what to do with that PR and if I can edit it... :D

Thanks j.r! I am comletely new to this Git-terry, so I first need to understand what to do with that PR and if I can edit it... :D

Should be fixed in !32. Could you take a look on it?

It’s good, thanks, but I wanted to try making a PR myself for the first time..
Anyway, I wasn’t done with the issue, it’s completed now and I added many things, you can see all the changes easily by looking at the texts in bold print. You can either add them yourself to the PR or give me the permission to do that too, if it’s possible.

> Should be fixed in !32. Could you take a look on it? It’s good, thanks, but I wanted to try making a PR myself for the first time.. Anyway, I wasn’t done with the issue, it’s completed now and I added many things, you can see all the changes easily by looking at the texts in bold print. You can either add them yourself to the PR or give me the permission to do that too, if it’s possible.
Collaborator
Copy link

I'll adjust my PR

I'll adjust my PR
Collaborator
Copy link

@PeaceOfBread okay I added everything now

@PeaceOfBread okay I added everything now

@PeaceOfBread okay I added everything now

All looks well, thanks a lot! :D I think I reviewed it now, if not, please tell me how to do it. This closes my issue.

> @PeaceOfBread okay I added everything now All looks well, thanks a lot! :D I think I reviewed it now, if not, please tell me how to do it. This closes my issue.
Sign in to join this conversation.
No Branch/Tag specified
master
testing
No results found.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nuron/timecheck#31
Reference in a new issue
nuron/timecheck
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?