refactor status storage #21

jonas-l commented 2020年06月16日 11:04:15 +02:00

I am not sure if splitting the status into multiple files is the optimal solution, e.g. the config is saved as one single file

Yeah this is not perfect.

talking of TimeLimit, I count the used times in a sqlite table which stores the time per day number (days since 1970) and relevant time slot (e.g. from 6 to 9 o clock); old entries are deleted after some time; maybe to complex for this use case, but maybe some aspects of this can be useful

I don't think that sqlite is a good option here because we try to keep the dependencys as low as possible....

Then I think putting all variables into a file (like the config file) would be a good idea

> I am not sure if splitting the status into multiple files is the optimal solution, e.g. the config is saved as one single file > Yeah this is not perfect. > talking of TimeLimit, I count the used times in a sqlite table which stores the time per day number (days since 1970) and relevant time slot (e.g. from 6 to 9 o clock); old entries are deleted after some time; maybe to complex for this use case, but maybe some aspects of this can be useful > I don't think that sqlite is a good option here because we try to keep the dependencys as low as possible.... Then I think putting all variables into a file (like the config file) would be a good idea

j.r commented 2020年06月16日 18:28:29 +02:00

And then just source this file?

And then just source this file?

jonas-l commented 2020年06月16日 20:46:20 +02:00

The config file is not sourced but parsed, so I think sourcing a status file (which - in contract to the config file - must be writable by the script itself) is not a good idea.

The config file is not sourced but parsed, so I think sourcing a status file (which - in contract to the config file - must be writable by the script itself) is not a good idea.

j.r commented 2020年06月16日 21:10:34 +02:00

Yeah didn't though about the writing part.... but the status file must not really be writeable by humans so we could just write one value per line in a predefined order or so.

Yeah didn't though about the writing part.... but the status file must not really be writeable by humans so we could just write one value per line in a predefined order or so.

jonas-l commented 2020年06月17日 07:36:33 +02:00

Why not like the config file:

[status file] -> [status file content] | [empty]
[status file content] -> [config line] [newline] [status file content] | [config line]
[config line] -> [key]=[value] | (space|tab)*
[key] -> (any character except =)*
[value] -> (any character except newline)*

Another aspect: Is there any reason why you're saving the config, script and status in the same directory?

Why not like the config file: ``` [status file] -> [status file content] | [empty] [status file content] -> [config line] [newline] [status file content] | [config line] [config line] -> [key]=[value] | (space|tab)* [key] -> (any character except =)* [value] -> (any character except newline)* ``` Another aspect: Is there any reason why you're saving the config, script and status in the same directory?

j.r commented 2020年06月17日 19:42:26 +02:00

Another aspect: Is there any reason why you're saving the config, script and status in the same directory?

There is no real reason I think...

Why not like the config file:

Yeah thats probably the best way

> Another aspect: Is there any reason why you're saving the config, script and status in the same directory? There is no real reason I think... > Why not like the config file: Yeah thats probably the best way

nuron commented 2020年07月22日 15:50:54 +02:00

Another aspect: Is there any reason why you're saving the config, script and status in the same directory?

There is no real reason I think...

No, there is no reason. Was just my first idea.

Why not like the config file:

Yeah thats probably the best way

yes. But I'm not that experienced with sed yet.

> > Another aspect: Is there any reason why you're saving the config, script and status in the same directory? > > There is no real reason I think... No, there is no reason. Was just my first idea. > > Why not like the config file: > > Yeah thats probably the best way yes. But I'm not that experienced with sed yet.