add default user-agent? #194

bradh commented 2026年04月27日 03:00:44 +02:00

Given recent changes on Overpass API, should there be a default user agent?

headers={"Accept-Charset": "utf-8;q=0.7,*;q=0.7", 'User-Agent': 'overpass-api-python-wrapper 0.7' }

As an alternative, should overpass.API() have a required user_agent argument that gets appended to the default headers? That way, different library users would be distinguishable.

Happy to propose a change (PR), just wanted to get input on the preferred approach.

Given recent changes on Overpass API, should there be a default user agent? ``` headers={"Accept-Charset": "utf-8;q=0.7,*;q=0.7", 'User-Agent': 'overpass-api-python-wrapper 0.7' } ``` As an alternative, should `overpass.API()` have a required `user_agent` argument that gets appended to the default headers? That way, different library users would be distinguishable. Happy to propose a change (PR), just wanted to get input on the preferred approach.

mvexel commented 2026年05月03日 18:51:47 +02:00

We should have a required User-Agent.

I have this planned for the 1.0 release, but if you want to create a patch for 0.8.x, that's great too!

We should have a required `User-Agent`. I have this planned for the 1.0 release, but if you want to create a patch for 0.8.x, that's great too!

bradh commented 2026年05月04日 00:33:09 +02:00

I'll give that a try.

However I'm not sure which change you would prefer:

• Option A: modify headers string to provide a default for the User-Agent
• Option B: add a required argument to the API() method
• (or, new variation, Option C): add a default to the headers and an optional argument to the API() method

Options A and C look easier to use, but Option B is less likely to result in all users being banned just because one user abused the service.

I'll give that a try. However I'm not sure which change you would prefer: - Option A: modify `headers` string to provide a default for the `User-Agent` - Option B: add a required argument to the `API()` method - (or, new variation, Option C): add a default to the `headers` and an optional argument to the `API()` method Options A and C look easier to use, but Option B is less likely to result in all users being banned just because one user abused the service.

bradh commented 2026年05月04日 00:35:22 +02:00

Ah, never mind. I've just seen the DESIGN document.

Ah, never mind. I've just seen the DESIGN document.