Validate verbosity tokens for Overpass QL #185

mvexel commented 2026年01月05日 21:54:29 +01:00

Add validation for verbosity strings (ids/skel/body/tags/meta plus optional modifiers like geom/bb/center and sort tokens). Provide clear error messages when invalid tokens are passed.

Add validation for verbosity strings (ids/skel/body/tags/meta plus optional modifiers like geom/bb/center and sort tokens). Provide clear error messages when invalid tokens are passed.

joachim-n commented 2026年06月04日 17:20:30 +02:00

Yup, if I specify 'tags' I get this crash:

 File "[...]/script.py", line 19, in get_osm_data
 data = api.get('way(42.819,-73.881,42.820,-73.880);(._;>;)', verbosity='tags')
 File "[...]/venv/lib/python3.14/site-packages/overpass/api.py", line 230, in get
 return json2geojson(response)
 File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 70, in json2geojson
 return _json2geojson(
 data, filter_used_refs, log_level, area_keys, polygon_features, raise_on_failure
 )
 File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 127, in _json2geojson
 for shape in _json2shapes(
 ~~~~~~~~~~~~^
 data, filter_used_refs, log_level, area_keys, polygon_features, raise_on_failure
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 ):
 ^
 File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 152, in _json2shapes
 shape = element_to_shape(
 el, refs_index, area_keys, polygon_features, raise_on_failure=raise_on_failure
 )
 File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 192, in element_to_shape
 return node_to_shape(el)
 File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 233, in node_to_shape
 return {"shape": Point(node["lon"], node["lat"]), "properties": get_element_props(node)}
 ```

Yup, if I specify 'tags' I get this crash: ``` File "[...]/script.py", line 19, in get_osm_data data = api.get('way(42.819,-73.881,42.820,-73.880);(._;>;)', verbosity='tags') File "[...]/venv/lib/python3.14/site-packages/overpass/api.py", line 230, in get return json2geojson(response) File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 70, in json2geojson return _json2geojson( data, filter_used_refs, log_level, area_keys, polygon_features, raise_on_failure ) File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 127, in _json2geojson for shape in _json2shapes( ~~~~~~~~~~~~^ data, filter_used_refs, log_level, area_keys, polygon_features, raise_on_failure ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ): ^ File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 152, in _json2shapes shape = element_to_shape( el, refs_index, area_keys, polygon_features, raise_on_failure=raise_on_failure ) File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 192, in element_to_shape return node_to_shape(el) File "[...]/venv/lib/python3.14/site-packages/osm2geojson/main.py", line 233, in node_to_shape return {"shape": Point(node["lon"], node["lat"]), "properties": get_element_props(node)} ```