2
0
Fork
You've already forked ds
0

modern-normalize not bundled currently #6

Open
opened 2026年01月18日 21:19:21 +01:00 by rdela · 2 comments
rdela commented 2026年01月18日 21:19:21 +01:00 (Migrated from github.com)
Copy link

So, speaking of Xeo in #5 ...

We may have discussed this in the past, but part of the reason I brought in ds.css locally in Xeo, is because modern-normalize does not get bundled in here and I was not sure what to do about that at the time.

Here I am adding it in Xeo’s ds.css github.com/famebot/xeo@b8c6d57203/_includes/css/ds.css (L8)

Here is the issue in ds/package.json:

github.com/lumeland/ds@6d78223fe4/package.json (L23)

We cp modern-normalize.css but the copied file does not get bundled in the second step, && postcss src/main.css -o ds.css, because it is not imported in src/main.css: github.com/lumeland/ds@6d78223fe4/src/main.css (L1-L16)

or in https://github.com/lumeland/ds/blob/main/src/reset.css

So maybe we don’t need it? But if we want it, we need to import it somewhere, unless I am missing something.

So, speaking of Xeo in #5 ... We may have discussed this in the past, but part of the reason I brought in `ds.css` locally in Xeo, is because `modern-normalize` does not get bundled in here and I was not sure what to do about that at the time. Here I am adding it in Xeo’s `ds.css` https://github.com/famebot/xeo/blob/b8c6d5720320e0da06dbd45b504c1b60a1a20f65/_includes/css/ds.css#L8 Here is the issue in `ds/package.json`: https://github.com/lumeland/ds/blob/6d78223fe4f4d8a70519dbea15da122debefe51d/package.json#L23 We `cp` `modern-normalize.css` but the copied file does not get bundled in the second step, `&& postcss src/main.css -o ds.css`, because it is not imported in `src/main.css`: https://github.com/lumeland/ds/blob/6d78223fe4f4d8a70519dbea15da122debefe51d/src/main.css#L1-L16 or in https://github.com/lumeland/ds/blob/main/src/reset.css So maybe we don’t need it? But if we want it, we need to import it somewhere, unless I am missing something.
rdela commented 2026年01月18日 21:21:56 +01:00 (Migrated from github.com)
Copy link

Also while I am bringing it up, we could update from v2 to v3 https://github.com/sindresorhus/modern-normalize/releases

Also while I am bringing it up, we could update from v2 to v3 https://github.com/sindresorhus/modern-normalize/releases

The latest changes in the DS repository haven't been published yet. In Simple-* themes I'm using the previous version

Initially this project was based on UI-normalize an opinionated normalize library that I created to build UIs and it has modern-normalize embeded.

My idea is to remove this dependency to reduce complexity and because it's easier to customize the components if everything is in the same repository. I started this task months ago but then I stopped because I focused on other things and forgot about this.

But yeah, I should resume this task

The latest changes in the DS repository haven't been published yet. In Simple-* themes [I'm using the previous version](https://github.com/lumeland/theme-simple-wiki/blob/main/src/styles.css#L2) Initially this project was based on [UI-normalize](https://github.com/oscarotero/ui-normalize) an opinionated normalize library that I created to build UIs and it has modern-normalize embeded. My idea is to remove this dependency to reduce complexity and because it's easier to customize the components if everything is in the same repository. I started this task [months ago](https://github.com/lumeland/ds/commit/6d78223fe4f4d8a70519dbea15da122debefe51d) but then I stopped because I focused on other things and forgot about this. But yeah, I should resume this task
Sign in to join this conversation.
No Branch/Tag specified
main
v0.6
v0.5.2
v0.5.1
v0.3.3
v0.3.1
v0.3.0
v0.2.4
v0.2.3
v0.2.1
v0.2.0
v0.1.1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lume/ds#6
Reference in a new issue
lume/ds
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?