keyoxide/keyoxide-web
26
329
Fork
You've already forked keyoxide-web
39

Move claim SVG icons from external server to be served locally #197

Open
opened 2024年03月27日 19:24:19 +01:00 by downey · 1 comment

Proposal

Currently in https://codeberg.org/keyoxide/keyoxide-web/src/branch/dev/views/profile.pug#L24 SVG images for each claim are being pulled from an external server, design.keyoxide.org. For privacy and other considerations, it would be useful to include these static images with the rest of the images that are shipped in the web application, e.g., under the /static/ directory path.

### Proposal Currently in https://codeberg.org/keyoxide/keyoxide-web/src/branch/dev/views/profile.pug#L24 SVG images for each claim are being pulled from an external server, `design.keyoxide.org`. For privacy and other considerations, it would be useful to include these static images with the rest of the images that are shipped in the web application, e.g., under the `/static/` directory path.

FWIW: I have designed my own homepage to have a switch, so I can control whether I want to host them locally with the project or from a certain subdomain. Controlled by an environment variable.

FWIW: I have designed my own homepage to have a switch, so I can control whether I want to host them locally with the project or from a certain subdomain. Controlled by an environment variable.
Sign in to join this conversation.
dev
main
dev
redesign-2023
add-logging
5.1.0
5.0.1
5.0.0
5.0.0-rc.1
4.2.7
4.2.6
4.2.5
4.2.4
4.2.3
4.2.2
4.2.1
4.2.0
4.1.1
4.1.0
4.0.2
4.0.1
4.0.0
3.6.4
3.6.3
3.6.2
3.6.1
3.6.0
3.5.2
3.5.1
3.5.0
3.4.18
3.4.17
3.4.16
3.4.15
3.4.14
3.4.13
3.4.12
3.4.11
3.4.10
3.4.9
3.4.8
3.4.7
3.4.6
3.4.5
3.4.4
3.4.3
3.4.2
3.4.1
3.4.0
3.3.1
3.3.0
3.2.0
3.1.1
3.1.0
3.0.4
3.0.3
3.0.2
3.0.1
3.0.0
2.5.0
2.4.2
2.4.1
2.4.0
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.8
2.2.7
2.2.6
2.2.5
2.2.4
2.2.3
2.2.2
2.2.1
2.2.0
2.1.1
2.1.0
2.0.2
2.0.1
2.0.0
2.0.0-rc.3
2.0.0-rc.2
2.0.0-rc.1
1.0.0
0.4.0
0.3.1
0.3.0
0.2.1
0.2.0
0.1.0
Labels
Clear labels
bug
Something is not working

Archived

contribution welcome
Contributions are very welcome, get started here

Archived

enhancement
New feature

Archived

good first issue
Interested in contributing? Get started here.

Archived

Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
 Affects the people using the project
Impact
Internal
 Affects on the people working on the project
Priority
Critical
 Work on right now
Priority
High
 Work on at earliest convenience
Priority
Low
 Work on in spare time
Priority
Medium
 Work on regularly
Review
Duplicate
 Already exists
Review
Off Topic
 Does not fall within the scope of the repo/project
Status
Backlog
 Is not being worked on yet
Status
Blocked
 Is waiting on something or someone
Status
Completed
 Is done
Status
In Progress
 Is being worked on
Status
Investigating
 Is waiting on research or questions
Status
Needs Decision
 Is waiting on a decision by the devs/contributors
Status
Needs Info
 Is waiting on additional information before it can be solved
Status
Needs Triage
 Is new issue that needs reviewing
Status
Testing
 Is being checked and verified
Status
Waiting For Review
 Is waiting on reviewers to approve
Status
Won't Fix
 Won't be fixed
Type
Bug
 Related to something not working as intended
Type
CI
 Related to continuous integration
Type
Documentation
 Related to documentation
Type
Enhancement
 Related to a new feature or an improved one
Type
New Claim
 Related to a new identity claim/proof
Type
Security
 Related to security
Type
Tests
 Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/keyoxide-web#197
Reference in a new issue
keyoxide/keyoxide-web
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?