PyPI release? #5

jayvdb commented 2019年07月12日 08:43:55 +02:00 (Migrated from github.com)

Do you plan to make this an installable module?

This tool is still more useful and better than the quite popular https://github.com/dbohdan/remarshal

Do you plan to make this an installable module? This tool is still more useful and better than the quite popular https://github.com/dbohdan/remarshal

kseistrup commented 2019年07月12日 09:21:18 +02:00 (Migrated from github.com)

Thanks for your attention.

To be honest, I have never thought about it as I always use it from the commandline.

I'll think about it, but please don't hold you breath.

Thanks for your attention. To be honest, I have never thought about it as I always use it from the commandline. I'll think about it, but please don't hold you breath.

kseistrup commented 2019年08月27日 10:19:08 +02:00 (Migrated from github.com)

Just thinking aloud here:

I think it would be useful if each serialization method had its own file with a common API.

Just thinking aloud here: I think it would be useful if each serialization method had its own file with a common API.

jayvdb commented 2019年08月27日 16:48:19 +02:00 (Migrated from github.com)

I think the current structure is OK. The main missing bit for API usage is a config object helper, which would be something like:

def build_config(input, output, **kwargs):
 return SimpleNamespace(
 input=input,
 output=output,
 force=False,
 sort=False,
 color=None,
 ).update(kwargs)

The other important aspect is tests, but that isnt necessary for the first PyPI release. Creating the tests might be a bit easier with some restructuring to make a common API, but I think that could be a gradual thing done in private modules until the new structure is ready to be made public.

I think the current structure is OK. The main missing bit for API usage is a config object helper, which would be something like: ```py def build_config(input, output, **kwargs): return SimpleNamespace( input=input, output=output, force=False, sort=False, color=None, ).update(kwargs) ``` The other important aspect is tests, but that isnt necessary for the first PyPI release. Creating the tests might be a bit easier with some restructuring to make a common API, but I think that could be a gradual thing done in private modules until the new structure is ready to be made public.

kseistrup commented 2019年08月28日 07:29:52 +02:00 (Migrated from github.com)

Thanks!

Thanks!