1
5
Fork
You've already forked app-template
1

Update to latest gradle version #2

Closed
solonovamax wants to merge 1 commit from buildscript/update-gradle-wrapper into main
pull from: buildscript/update-gradle-wrapper
merge into: java-gi:main
java-gi:main
solonovamax commented 2025年12月10日 23:41:48 +01:00 (Migrated from github.com)
Copy link

Updates gradle to the latest version, which is 9.2.1

This PR is based on #1

Also adds the distributionSha256Sum property for the gradle distribution

Updates gradle to the latest version, which is 9.2.1 This PR is based on #1 Also adds the `distributionSha256Sum` property for the gradle distribution
jwharm commented 2025年12月11日 20:06:53 +01:00 (Migrated from github.com)
Copy link

Similarly to my comment in PR #3, we can't use the Gradle wrapper in an offline flatpak build. The flatpak build is currently setup to run the Gradle distribution that is included in the OpenJDK extension to the Freedesktop SDK used by GNOME 48, and that is Gradle 8.12.1.
The Gradle Wrapper can still be useful for people who want to build and run the app locally, but for consistency, it should be the 8.12.1 wrapper.

Similarly to my comment in PR #3, we can't use the Gradle wrapper in an offline flatpak build. The flatpak build is currently setup to run the Gradle distribution that is included in the OpenJDK extension to the Freedesktop SDK used by GNOME 48, and that is Gradle 8.12.1. The Gradle Wrapper can still be useful for people who want to build and run the app locally, but for consistency, it should be the 8.12.1 wrapper.
solonovamax commented 2025年12月12日 04:46:41 +01:00 (Migrated from github.com)
Copy link

Similarly to my comment in PR #3, we can't use the Gradle wrapper in an offline flatpak build. The flatpak build is currently setup to run the Gradle distribution that is included in the OpenJDK extension to the Freedesktop SDK used by GNOME 48, and that is Gradle 8.12.1.
The Gradle Wrapper can still be useful for people who want to build and run the app locally, but for consistency, it should be the 8.12.1 wrapper.

ah, I see

in that case, I should downgrade it from 9.0.0 -> 8.12.1 (you had it set to 9.0.0), yeah?

> Similarly to my comment in PR #3, we can't use the Gradle wrapper in an offline flatpak build. The flatpak build is currently setup to run the Gradle distribution that is included in the OpenJDK extension to the Freedesktop SDK used by GNOME 48, and that is Gradle 8.12.1. > The Gradle Wrapper can still be useful for people who want to build and run the app locally, but for consistency, it should be the 8.12.1 wrapper. ah, I see in that case, I should downgrade it from 9.0.0 -> 8.12.1 (you had it set to 9.0.0), yeah?
jwharm commented 2025年12月12日 21:25:45 +01:00 (Migrated from github.com)
Copy link

Yes please.
I didn’t think of this when I added the wrapper.

Yes please. I didn’t think of this when I added the wrapper.
jwharm commented 2026年02月05日 21:32:51 +01:00 (Migrated from github.com)
Copy link

Cleaning up stale PRs

Cleaning up stale PRs

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
java-gi/app-template!2
Reference in a new issue
java-gi/app-template
No description provided.
Delete branch "buildscript/update-gradle-wrapper"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?