Lines 61 to 62 in 57cac0d
// Warning to those adding: the code that uses this (commits check, and
// contributors check) is generally only doing the first "word" of the name.
Noticed this issue while making additional stuff after #2
Lines 361 to 369 in 57cac0d
// XXX: don't use only the first word of a name, maybe do the
// whole name and email (risk of claude opus 4.5 updating to a
// different version, regex?)
const name = message_co_author_parts[1].split(" ")[0];
if (bot_names_to_look_for.has(name.toLowerCase())) {
console.debug(`AI bot co-author found in SHA ${commit_info.sha}:`, commit_info.commit.message);
bots.push({"name": name, "sha": commit_info.sha});
continue;
}
Some considerations which I think is related:
- Both commits and contributors use the same
check_userfunction, which probably won't work when things are done correctly, because of account name difference- (I need to double check whatever I said here makes sense at all in the first place, this thought comes from that last time I properly looked at the code)
https://codeberg.org/jacksonchen666/userscripts/src/commit/57cac0d141bf3b29f9b7b47d1db9f1d67c6a9f3d/github.com-notify-on-ai-files.user.js#L61-L62
Noticed this issue while making additional stuff after #2
https://codeberg.org/jacksonchen666/userscripts/src/commit/57cac0d141bf3b29f9b7b47d1db9f1d67c6a9f3d/github.com-notify-on-ai-files.user.js#L361-L369
Some considerations which I think is related:
- Both commits and contributors use the same `check_user` function, which probably won't work when things are done correctly, because of account name difference
- (I need to double check whatever I said here makes sense at all in the first place, this thought comes from that last time I properly looked at the code)