Commits check for co-authors only checks first co-author, not all #17

jacksonchen666 commented 2026年03月31日 22:01:47 +02:00

(Original title, for context: Userscript is suspiciously silent about a commit that should match and alert)

github.com/element-hq/synapse@f545aa4f33

Preserved in https://github.com/JacksonChen666/synapse_2026年03月31日

My logs:

21:52:51.288 looking at commit SHA f545aa4f33377f2c68aad7032afbe5a395c35cbc position 17 Detect AI instruction files in GitHub repos.user.js:1182:21
21:52:51.288 check_user user: erikjohnston (type User) Detect AI instruction files in GitHub repos.user.js:1094:13
21:52:51.288 commit co-author parts 
Array(3) [ "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n", "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n", "Copilot <175728472+Copilot@users.noreply.github.com>" ]
​
0: "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n"
​
1: "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n"
​
2: "Copilot <175728472+Copilot@users.noreply.github.com>"
​
length: 3
​
<prototype>: Array []
Detect AI instruction files in GitHub repos.user.js:1219:25

This is only 17 commits from the develop branch, and seems to have copilot as the co-author.

Thanks for @olivia-l for noticing!

(Original title, for context: Userscript is suspiciously silent about a commit that should match and alert) https://github.com/element-hq/synapse/commit/f545aa4f33377f2c68aad7032afbe5a395c35cbc Preserved in https://github.com/JacksonChen666/synapse_2026年03月31日 My logs: ``` 21:52:51.288 looking at commit SHA f545aa4f33377f2c68aad7032afbe5a395c35cbc position 17 Detect AI instruction files in GitHub repos.user.js:1182:21 21:52:51.288 check_user user: erikjohnston (type User) Detect AI instruction files in GitHub repos.user.js:1094:13 21:52:51.288 commit co-author parts Array(3) [ "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n", "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n", "Copilot <175728472+Copilot@users.noreply.github.com>" ] ​ 0: "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n" ​ 1: "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n" ​ 2: "Copilot <175728472+Copilot@users.noreply.github.com>" ​ length: 3 ​ <prototype>: Array [] Detect AI instruction files in GitHub repos.user.js:1219:25 ``` This is only 17 commits from the `develop` branch, and seems to have copilot as the co-author. Thanks for @olivia-l for noticing!

jacksonchen666 commented 2026年04月25日 01:06:18 +02:00

Found the bug.

It is only checking the first co-author. There can be multiple co-authors.

Critical, because IIRC "AI" is generally the last co-author, I think. I'm not sure, but this behavior is not correct anyways, since there can be multiple co-authors.

---

Logs with added debug statement:

01:01:40.330 looking at commit SHA f545aa4f33377f2c68aad7032afbe5a395c35cbc position 17 Detect AI instruction files in GitHub repos.user.js:256:21
01:01:40.330 check_user user: erikjohnston (type User) Detect AI instruction files in GitHub repos.user.js:164:13
01:01:40.330 commit co-author parts 
Array(3) [ "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n", "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n", "Copilot <175728472+Copilot@users.noreply.github.com>" ]
0: "[...]"
1: "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n"
2: "Copilot <175728472+Copilot@users.noreply.github.com>"
length: 3
<prototype>: Array []
Detect AI instruction files in GitHub repos.user.js:293:25
01:01:40.330 co-author name part: Andrew Detect AI instruction files in GitHub repos.user.js:298:25

Found the bug. https://codeberg.org/jacksonchen666/userscripts/src/commit/274cfa2de27745d9bfcda209436a89ee646910e6/github.com-notify-on-ai-files.user.js#L287-L293 It is only checking the *first* co-author. There can be multiple co-authors. Critical, because IIRC "AI" is generally the last co-author, *I think*. I'm not sure, but this behavior is not correct anyways, since there can be multiple co-authors. --- Logs with added debug statement: ``` 01:01:40.330 looking at commit SHA f545aa4f33377f2c68aad7032afbe5a395c35cbc position 17 Detect AI instruction files in GitHub repos.user.js:256:21 01:01:40.330 check_user user: erikjohnston (type User) Detect AI instruction files in GitHub repos.user.js:164:13 01:01:40.330 commit co-author parts Array(3) [ "Port `RoomVersion` to Rust (#19589)\n\nPrincipally so that we can share the same room version configuration\nbetween Python and Rust.\n\nFor the most part, this is a direct port. Some special handling has had\nto go into `KNOWN_ROOM_VERSIONS` so that it can be sensibly shared\nbetween Python and Rust, since we do update it during config parsing.\n\n---------\n\n", "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n", "Copilot <175728472+Copilot@users.noreply.github.com>" ] 0: "[...]" 1: "Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>\n" 2: "Copilot <175728472+Copilot@users.noreply.github.com>" length: 3 <prototype>: Array [] Detect AI instruction files in GitHub repos.user.js:293:25 01:01:40.330 co-author name part: Andrew Detect AI instruction files in GitHub repos.user.js:298:25 ```

jacksonchen666 commented 2026年04月25日 01:14:27 +02:00

git blame traces it back to #2. I guess I didn't review the code that well. (Or honestly at all)

git blame traces it back to #2. I guess I didn't review the code that well. (Or honestly at all)

jacksonchen666 commented 2026年05月10日 07:25:32 +02:00

Released in userscript version 0.4.0!

Released in userscript version 0.4.0!