Clarifying not all checks were run #13

jacksonchen666 commented 2026年02月24日 02:42:22 +01:00

Someone using the userscript brought up that they got a commits notification, but were confused about the lack of files notifications, as the commits were external contributors (which is why 5a09c0d036 was done).

That's because the userscript doesn't check everything if something else triggers it first (commits was first before files) to save API requests, but that is not clear if you never read the website's usage section, and I'm the dev so it's obvious to me why that's the case but not to others.

Could either run all checks (as a button or setting) or note checks skipped and checks that found nothing.

Someone using the userscript brought up that they got a commits notification, but were confused about the lack of files notifications, as the commits were external contributors (which is why 5a09c0d036d309caf34b2202ba62cd62e9d399e1 was done). That's because the userscript doesn't check everything if something else triggers it first (commits was first before files) to save API requests, but that is not clear if you never read the website's usage section, and I'm the dev so it's obvious to me why that's the case but not to others. Could either run all checks (as a button or setting) or note checks skipped and checks that found nothing.

jacksonchen666 commented 2026年02月25日 04:46:46 +01:00

I think this is even more important if I want to make files the first check again, since files in the repos would imply maintainer approval, but if that doesn't work (false positive) then other checks would be helpful. (I may be wordsn't in this comment)

I think this is even more important if I want to make files the first check again, since files in the repos would imply maintainer approval, but if that doesn't work (false positive) then other checks would be helpful. (I may be wordsn't in this comment)

jacksonchen666 commented 2026年04月11日 11:09:15 +02:00

Hmmm, ran into a case where commits thrown first but then I immediately noticed a file, which the userscript doesn't say much about. Maybe could conditionally disable contributors check if other checks have something, so it ends up with commits + files (and no contributors check) or contributors check (with nothing found for commits + files)?

Hmmm, ran into a case where commits thrown first but then I immediately noticed a file, which the userscript doesn't say much about. Maybe could conditionally disable contributors check if other checks have something, so it ends up with commits + files (and no contributors check) or contributors check (with nothing found for commits + files)?