ivy support #4

velkyel commented 2019年04月27日 10:55:26 +02:00 (Migrated from github.com)

please add ivy support.

please add ivy support.

fourier commented 2019年04月27日 21:54:51 +02:00

Could you please elaborate a little? What exactly is ivy support ? As I've never used ivy.

Could you please elaborate a little? What exactly is ivy support ? As I've never used ivy.

velkyel commented 2019年04月27日 22:39:42 +02:00 (Migrated from github.com)

of course. Ivy is alternative to helm. I imagine new variable

(defvar cff-use-ivy-choice t
 "Determines what to do if there are several possible choices.
If t, use ivy if available.
If nil, always use internal choice mode.")

and proper code changes. integration should be easy, I think. I have migrated from helm to ivy recently so I don't know ivy api at this time well to make good patch. If I'm the only one needs it and you don't use ivy then you can close this issue and I will do pull request when I'll find time and write it.
nice package anyway, I'm using it on daily base.

of course. Ivy is alternative to helm. I imagine new variable ``` (defvar cff-use-ivy-choice t "Determines what to do if there are several possible choices. If t, use ivy if available. If nil, always use internal choice mode.") ``` and proper code changes. integration should be easy, I think. I have migrated from helm to ivy recently so I don't know ivy api at this time well to make good patch. If I'm the only one needs it and you don't use ivy then you can close this issue and I will do pull request when I'll find time and write it. nice package anyway, I'm using it on daily base.

velkyel commented 2019年05月04日 17:32:22 +02:00 (Migrated from github.com)

pull request #5

pull request #5

fourier commented 2019年05月06日 10:45:23 +02:00

Thanks for digging into it, reviewed.

Thanks for digging into it, reviewed.

velkyel commented 2019年05月10日 15:25:00 +02:00 (Migrated from github.com)

I've just discover built-in ff-find-other-file which do the same as cff and has better semantics in advance (for example find closer file for same base name).

I've just discover built-in ff-find-other-file which do the same as cff and has better semantics in advance (for example find closer file for same base name).

fourier commented 2019年05月12日 13:06:31 +02:00

Yea I know about ff-find-other-file, don't really remember why I've decided to implement cff back then when. Maybe wanted to have future proof or adaptable for different kind of projects, can't say now.

Yea I know about ff-find-other-file, don't really remember why I've decided to implement cff back then when. Maybe wanted to have future proof or adaptable for different kind of projects, can't say now.